set permissions on $abs_profiled and shellcheck config

- [x] don't assume system umask will create a readable
/etc/profile.d/golang_path.sh

- [x] fix typo in $dont_edit

- [x] use shellcheck disable directives directly inside `update-golang.sh`

Author: virgilwashere

update-golang.sh

@@ -6,6 +6,8 @@
 #
 # PIPETHIS_AUTHOR udhos
 
+# ignore runtime environment variables
+# shellcheck disable=SC2153
 version=0.20
 
 set -o pipefail
@@ -272,19 +274,21 @@ profile_path_add() {
     profile_path_remove
 
     msg profile_path_add: issuing new "$abs_gobin" to "$abs_profiled"
-    local dont_edit=";# DOT NOT EDIT: installed by $path_mark"
+    local dont_edit=";# DO NOT EDIT: installed by $path_mark"
     echo "export PATH=\$PATH:$abs_gobin $dont_edit" >> "$abs_profiled"
 
     local user_gobin=
     [ -n "$GOPATH" ] && user_gobin=$(echo "$GOPATH" | awk -F: '{print $1}')/bin
-    [ -z "$user_gobin" ] && user_gobin='$HOME/go/bin'
+    # shellcheck disable=SC2016
+    [ -z "$user_gobin" ] && user_gobin='$HOME/go/bin'         ;# we want $HOME literal
     msg profile_path_add: issuing "$user_gobin" to "$abs_profiled"
     echo "export PATH=\$PATH:$user_gobin $dont_edit" >> "$abs_profiled"
 
     if [ "$abs_goroot" != $default_goroot ]; then
         msg profile_path_add: setting up custom GOROOT="$abs_goroot" to "$abs_profiled"
         echo "export GOROOT=$abs_goroot $dont_edit" >> "$abs_profiled"
     fi
+    chmod 755 "$abs_profiled"
 }
 
 running_as_root() {

update-golang.sh.sha256

@@ -1 +1 @@
-2d890dfe07eab0700d14ccc282c1dd2ec737095e907b4cad3c71d1ec423d0e31  update-golang.sh
+6beb10c818f6dfc52d03803672b526acfabcb9b3fab231996e62366b95c0dd64  update-golang.sh