You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
From Google's docs on the Play Install Referrer library:
Closing service connection
After getting referrer information, call the endConnection() method on your InstallReferrerClient instance to close the connection. Closing the connection will help you avoid leaks and performance problems.
Describe the solution you'd like
I'm not very familiar with the specifics of this API, but it seems like the endConnection call can be made in the success case for onInstallReferrerSetupFinished.
Describe alternatives you've considered
It's not terrible to leave as-is if you avoid running the native module outside of the first run based on local storage lookups, but since the docs specifically instruct doing this, it probably would be best to just close the connection.
Additional context
N/A
The text was updated successfully, but these errors were encountered:
And sorry for quite a bit of delay in replying to this one.
Great catch and I believe that you are absolutely right - ending connection in OK case after getting a response sounds like a thing that should be done. 👍
I can add the change, but having in mind that you're the contributor to the idea itself - if you are willing to open a pull request to add that change, go for it, it would be my pleasure to merge it that way. In case you don't wanna bother with that, also good, I can add the change as well to the next update.
Is your feature request related to a problem? Please describe.
From Google's docs on the Play Install Referrer library:
Describe the solution you'd like
I'm not very familiar with the specifics of this API, but it seems like the
endConnection
call can be made in the success case foronInstallReferrerSetupFinished
.Describe alternatives you've considered
It's not terrible to leave as-is if you avoid running the native module outside of the first run based on local storage lookups, but since the docs specifically instruct doing this, it probably would be best to just close the connection.
Additional context
N/A
The text was updated successfully, but these errors were encountered: