Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Center Velocity as parameter for galaxy centering #29

Open
2 tasks
ufuk-cakir opened this issue May 4, 2024 · 0 comments
Open
2 tasks

Add Center Velocity as parameter for galaxy centering #29

ufuk-cakir opened this issue May 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ufuk-cakir
Copy link
Owner

Currently, during galaxy centering we calculate the median velocity of the galaxy center

central_velocity = jnp.median(stellar_velocities[mask], axis=0)

But some simulation contain information about the velocity of the galaxy, for example in Illustris the SubhaloVel.

TODO

  • load this field in the IllustrisAPI class: add this in the configuration yaml file
  • make the center_galaxy function take an optional center_velocity parameter: If given, use it, else calculate median velocity
@ufuk-cakir ufuk-cakir added the enhancement New feature or request label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant