Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report issues found while running overlap_collector back to user #1

Open
smason opened this issue Sep 30, 2021 · 2 comments
Open

report issues found while running overlap_collector back to user #1

smason opened this issue Sep 30, 2021 · 2 comments

Comments

@smason
Copy link
Contributor

smason commented Sep 30, 2021

if the operation failed, we should be reporting warnings and errors back as these probably indicate an issue with the input geometry that could turn out to be useful to the user

Helen's step file using broken sectioning code causes some internal errors to get set, which might be nice for testing!

@smason
Copy link
Contributor Author

smason commented Sep 30, 2021

might be nice to report warnings even in the case of success, maybe at debug level as they don't seem to have much effect

@smason
Copy link
Contributor Author

smason commented Dec 9, 2021

Colin's data file M31202352_A.stp has errors, need to run with --no-check-geometry

Might want to add a flag that still checks, but doesn't fail on errors

or maybe use exit codes better so we can differentiate between these cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant