Models for different property editors and corresponding values converters are (scattered) in multiple namespaces. #10590
soreng
started this conversation in
Features and ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
The new media pickers handles a value of type
MediaWithCrops
found inUmbraco.Core.Models
. OnMediaWithCrops
there is a property LocalCrops of typeImageCropperValue
. This is found inUmbraco.Cms.Core.PropertyEditors.ValueConverters
. The Crops property is of typeImageCropperCrop
, that is a class insiede theImageCropperValue
. All the models seem to be in the Umbraco.Infrastructure assembly.Link
that is used by the Multi Url Picker, lives inUmbraco.Cms.Core.Models
, found in the assemblyUmbraco.Core
.It seems like a bit of an oversight, and you end up with a lof of usings scattered in views / configuration. This may be caused by the Multi Url Picker being a bit old, but as a guide for a PR, it would be nice to know the preffered naming.
Beta Was this translation helpful? Give feedback.
All reactions