From 5d49eaa15112a7c4f4f7f0bf25b3c7336485b374 Mon Sep 17 00:00:00 2001 From: Jonny Muir Date: Mon, 17 Feb 2025 22:02:16 +0000 Subject: [PATCH 1/3] test: create failing test to show webkit failing on svg size --- packages/uui-icon/lib/uui-icon.test.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/uui-icon/lib/uui-icon.test.ts b/packages/uui-icon/lib/uui-icon.test.ts index d241f5355..1aa0fff21 100644 --- a/packages/uui-icon/lib/uui-icon.test.ts +++ b/packages/uui-icon/lib/uui-icon.test.ts @@ -224,5 +224,13 @@ describe('UUIIconElement', () => { it('Child uui-icon passes the a11y audit', async () => { await expect(testElement.iconElement).shadowDom.to.be.accessible(); }); + + it('svg has a size of 18px for both width and height', () => { + const svgElement = + testElement.iconElement.shadowRoot!.querySelector('svg')!; + const computedStyle = getComputedStyle(svgElement); + expect(computedStyle.width).to.equal('18px'); + expect(computedStyle.height).to.equal('18px'); + }); }); }); From 19dd374ecaa7e085100e38a7ea2e06727fa57f0b Mon Sep 17 00:00:00 2001 From: Jonny Muir Date: Mon, 17 Feb 2025 22:47:45 +0000 Subject: [PATCH 2/3] fix: set svg width to 100% on UUIconElement --- packages/uui-icon/lib/uui-icon.element.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/uui-icon/lib/uui-icon.element.ts b/packages/uui-icon/lib/uui-icon.element.ts index d04d66988..c1afa389d 100644 --- a/packages/uui-icon/lib/uui-icon.element.ts +++ b/packages/uui-icon/lib/uui-icon.element.ts @@ -149,6 +149,7 @@ export class UUIIconElement extends LitElement { :host svg, ::slotted(svg) { color: var(--uui-icon-color, currentColor); + width: 100%; } :host-context(div[slot='prepend']) { From fe772dbd80153de722e53f1de4bb6c5066a18e15 Mon Sep 17 00:00:00 2001 From: Jonny Muir Date: Tue, 18 Feb 2025 21:26:22 +0000 Subject: [PATCH 3/3] fix: lint errors in drag.ts --- packages/uui-base/lib/utils/drag.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/uui-base/lib/utils/drag.ts b/packages/uui-base/lib/utils/drag.ts index 6b841b122..4a67cf0b4 100644 --- a/packages/uui-base/lib/utils/drag.ts +++ b/packages/uui-base/lib/utils/drag.ts @@ -25,10 +25,9 @@ export const drag = ( // TouchEvent is not available in Firefox if ('TouchEvent' in window && event instanceof TouchEvent) { pointerEvent = event.touches[0]; - } else if ( event instanceof PointerEvent ) { + } else if (event instanceof PointerEvent) { pointerEvent = event; - } - else { + } else { return; }