From 25361059965095666049a163b85faed0f4864de9 Mon Sep 17 00:00:00 2001 From: Lan Nguyen Thuy Date: Wed, 5 Mar 2025 09:58:01 +0700 Subject: [PATCH 1/3] make disabled menu item button more clear --- packages/uui-menu-item/lib/uui-menu-item.element.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/uui-menu-item/lib/uui-menu-item.element.ts b/packages/uui-menu-item/lib/uui-menu-item.element.ts index ce25e25d4..6c0d54852 100644 --- a/packages/uui-menu-item/lib/uui-menu-item.element.ts +++ b/packages/uui-menu-item/lib/uui-menu-item.element.ts @@ -311,10 +311,6 @@ export class UUIMenuItemElement extends SelectOnlyMixin( /** Disabled */ :host([disabled]) #menu-item { - color: var( - --uui-menu-item-color-disabled, - var(--uui-color-disabled-contrast) - ); background-color: var( --uui-menu-item-background-color-disabled, var(--uui-color-disabled) @@ -467,6 +463,7 @@ export class UUIMenuItemElement extends SelectOnlyMixin( :host([disabled]) #label-button { cursor: default; + opacity: 0.4; } button { From b9df953001a5ad5761f51d5b698a1c331b539cf4 Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Fri, 14 Mar 2025 10:01:26 +0100 Subject: [PATCH 2/3] Update packages/uui-menu-item/lib/uui-menu-item.element.ts --- packages/uui-menu-item/lib/uui-menu-item.element.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/uui-menu-item/lib/uui-menu-item.element.ts b/packages/uui-menu-item/lib/uui-menu-item.element.ts index 6c0d54852..96740c148 100644 --- a/packages/uui-menu-item/lib/uui-menu-item.element.ts +++ b/packages/uui-menu-item/lib/uui-menu-item.element.ts @@ -463,7 +463,7 @@ export class UUIMenuItemElement extends SelectOnlyMixin( :host([disabled]) #label-button { cursor: default; - opacity: 0.4; + opacity: 0.55; } button { From 18f36f9d07d469849b822a6d44bf29b994be4cef Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Fri, 14 Mar 2025 10:15:09 +0100 Subject: [PATCH 3/3] fix: set opacity a bit lower --- packages/uui-menu-item/lib/uui-menu-item.element.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/uui-menu-item/lib/uui-menu-item.element.ts b/packages/uui-menu-item/lib/uui-menu-item.element.ts index 96740c148..eb7958d00 100644 --- a/packages/uui-menu-item/lib/uui-menu-item.element.ts +++ b/packages/uui-menu-item/lib/uui-menu-item.element.ts @@ -463,7 +463,7 @@ export class UUIMenuItemElement extends SelectOnlyMixin( :host([disabled]) #label-button { cursor: default; - opacity: 0.55; + opacity: 0.5; } button {