Skip to content

no-duplicates autofix incorrectly combines type and non-type typescript imports #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steved-stripe opened this issue Feb 13, 2025 · 0 comments · May be fixed by #232
Open

no-duplicates autofix incorrectly combines type and non-type typescript imports #231

steved-stripe opened this issue Feb 13, 2025 · 0 comments · May be fixed by #232
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed PR welcome

Comments

@steved-stripe
Copy link

Before:

import {
  type ComponentToken,
  type ValidateAllPermissions,
  type ValidatePermissions,
  checkPermissions,
} from 'foo';
import type {FunctionParameterToken} from 'foo';

After:

import type {
  type ComponentToken,
  FunctionParameterToken,
  type ValidateAllPermissions,
  type ValidatePermissions,
  checkPermissions,
} from 'foo';

I think we'd ignore this case

@steved-stripe steved-stripe linked a pull request Feb 13, 2025 that will close this issue
@JounQin JounQin added enhancement New feature or request help wanted Extra attention is needed PR welcome bug Something isn't working labels Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed PR welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants