-
-
Notifications
You must be signed in to change notification settings - Fork 41
import-x/order mismatches typescript language server organize imports for #
prefixed imports
#286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It depends on where the final module path resolved, mostly, |
Hey @JounQin 🙂 I'm also not sure if this is an issue in But I'm potentially willing to implement the fix with a PR if I get some instructions where to start. 😺 |
There is no such convention?
I'm fine with adding a new option, but I don't know how to name it, you can give your choice via a PR. The sorting ranks happen at eslint-plugin-import-x/src/rules/order.ts Line 715 in 877bbbb
|
I'm not sure if there is something like it in In @simonhaenisch's This is then the same as calling it in VSCode manually: https://code.visualstudio.com/docs/typescript/typescript-refactoring#_organize-imports
OK thx, I will have a look into it after company work in my private time 👍 |
I know those tools follow TS LSP by using it under the hood, but cc @SukkaW |
Matching it is totally fine 👍 |
|
Minimal reproducible: https://github.com/Shinigami92/eslint-plugin-import-x-repro
input
actual
import-x/order
reports errorexpected
should not report, because when running typescript's lsp organize imports, then the above input order is enforced
context
the
#
prefix comes frompackage.json
"imports": { ... }
field: https://nodejs.org/api/packages.html#importsThe text was updated successfully, but these errors were encountered: