Is importing the package itself a good practice? Isn't it a circle dependency?

Yep indeed.

But it happens in my test files: they are importing the package to test it.

So the example is more like this:

index.js:

export const answer = 42;

tests/index.test.js:

import { answer } from "package-name";

if (answer !== 42) {
  throw new Error("answer should be 42");
}

I believe you should disable no-extraneous-dependencies rule for test files? The source and test should have different rules, and this plugin cannot determine that automatically.

My goal with this rule is mainly to ensure my dependencies are properly listed in the package.json. So I could disable it entirely for test files.

But ideally I could also use it to ensure my devDependencies are listed. So I would like an option like allowSelfImport that I would set to true only in test files. Is that something that make sense?

But ideally I could also use it to ensure my devDependencies are listed. So I would like an option like allowSelfImport that I would set to true only in test files. Is that something that make sense?

That could make sense, but I need to think about it more and discuss with others.

cc @Shinigami92 @SukkaW @thepassle

Can't you add it as internal devDependency?

Like I did in https://github.com/salsita/node-pg-migrate/blob/main/package.json#L114

Can't you add it as internal devDependency?

That would likely fix my issue indeed 🤔 I'll try this

(By the way I think file:. dependencies can be declared with ./, at least that works for me)

(By the way I think file:. dependencies can be declared with ./, at least that works for me)

By the way, I'd prefer link:. for yarn. 😁

In the end I've added the package name into my devDependencies as follow:

{
  "name": "package-name",
  "devDependencies": {
    "package-name": "./"
  }
}

For me it's a good enough way to be able to reference the package from test files while keeping import-x/no-extraneous-dependencies rule enabled.

Thanks to the quick responses and feedback.

Can this issue be closed then?

Can this be reopened? I like this rule, but it’s also the one I have to disable very often because of this issue. It looks easy to fix too. I’ll gladly provide a PR if this is accepted.

Is importing the package itself a good practice? Isn't it a circle dependency?

This was already brought up, but I think it’s a great practice to import a package using its name in test files. This tests whether the package exports are correct.

I believe you should disable no-extraneous-dependencies rule for test files? The source and test should have different rules, and this plugin cannot determine that automatically.

I agree they should have different rules. For tests I allow devDependencies in addition to the other kinds of dependencies. This rule is still useful for tests.

Can't you add it as internal devDependency?

That might work, but it would only be a workaround for this issue.

Hi, @remcohaszing.

Great to see you here!

A PR resolving this issue would be appreciated for sure! ❤️