Added logic to use the DisableTestHistory property for Suites

Author: AlexNetcare

FitNesseRoot/FitNesse/UserGuide/WritingAcceptanceTests/TestHistory/content.txt

@@ -11,7 +11,7 @@ The test result files are named using the following scheme !style_code(YYYYMMDDH
 
 The test files contain the XML that describes the test run.  The format of this XML is identical to the XML packet returned by the format=xml flag when you run a test.  (See <UserGuide.RestfulTests).
 
-You also have the possibility to disable !style_code(Test Histories) for a selected page by going to the !style_code(?properties) page and check the ''!-DisableTestHistory-!'' option.
+You also have the possibility to disable !style_code(Test Histories) for a selected page by going to the !style_code(?properties) page and check the ''!-DisableTestHistory-!'' option. Setting this property on a Suite, will disable the !style_code(Test Histories) for the whole Suite.
 
 !4 Purging
 There are buttons at the top of the ''Test History'' page that allow you to purge old history files.  You have your choice of ''all'', ''>7 days'', or ''>30 days''.  If you want to purge a different number of days, you can change the ''TestHistory.purgeOptions'' in the [[configuration file][<UserGuide.AdministeringFitNesse.ConfigurationFile]] to allow additional purge options, or you can use the RESTful URL form.  (See [[!-RestfulServices-!][<UserGuide.AdministeringFitNesse.RestfulServices]]).

src/fitnesse/reporting/history/TestXmlFormatter.java

@@ -176,8 +176,7 @@ protected void setTotalRunTimeOnReport(TimeMeasurement totalTimeMeasurement) {
   }
 
   protected void writeResults() throws IOException {
-    if (!getPage().getData().getProperties()
-        .has(WikiPageProperty.DISABLE_TESTHISTORY)) {
+    if (!getPage().getData().hasAttribute(WikiPageProperty.DISABLE_TESTHISTORY)) {
       writeResults(writerFactory.getWriter(context, getPage(), getPageCounts(),
           totalTimeMeasurement.startedAt()));
     }

src/fitnesse/responders/run/SuiteResponder.java

@@ -44,6 +44,7 @@
 import fitnesse.wiki.WikiImportProperty;
 import fitnesse.wiki.WikiPage;
 import fitnesse.wiki.WikiPagePath;
+import fitnesse.wiki.WikiPageProperty;
 import fitnesse.wiki.WikiPageUtil;
 import org.apache.commons.lang3.StringUtils;
 import util.FileUtil;
@@ -262,7 +263,8 @@ protected void addFormatters(MultipleTestsRunner runner) {
   }
 
   private boolean withSuiteHistoryFormatter() {
-    return !request.hasInput("nohistory");
+    return !request.hasInput("nohistory")
+        && !page.getData().hasAttribute(WikiPageProperty.DISABLE_TESTHISTORY);
   }
 
   protected void addHistoryFormatter(MultipleTestsRunner runner) {

test/fitnesse/responders/run/SuiteResponderTest.java

@@ -18,6 +18,7 @@
 import fitnesse.wiki.PageData;
 import fitnesse.wiki.PathParser;
 import fitnesse.wiki.WikiPage;
+import fitnesse.wiki.WikiPageProperty;
 import fitnesse.wiki.WikiPageUtil;
 import org.junit.After;
 import org.junit.Before;
@@ -483,6 +484,25 @@ public void NoHistory_avoidsProducingSuiteResultFile() throws Exception {
     assertFalse(xmlResultsFile.exists());
   }
 
+  @Test
+  public void DisableHistory_avoidsProducingSuiteResultFile() throws Exception {
+    File xmlResultsFile = expectedXmlResultsFile();
+
+    if (xmlResultsFile.exists())
+      xmlResultsFile.delete();
+    
+    PageData data = suite.getData();
+    data.setAttribute(WikiPageProperty.DISABLE_TESTHISTORY);
+    suite.commit(data);
+    suite.getData();
+    responder.page = suite;
+    
+    addTestToSuite("SlimTestOne", simpleSlimDecisionTable);
+    addTestToSuite("SlimTestTwo", simpleSlimDecisionTable);
+    runSuite();
+    assertFalse(xmlResultsFile.exists());
+  }
+
   @Test
   public void Includehtml_producesHTMLResultsInXMLSuite() throws Exception {
     request.addInput("format", "xml");