fix: class metadata as attribute

Author: Matej Grgić

rector.php

@@ -3,15 +3,12 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Set\ValueObject\LevelSetList;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->paths([
+return RectorConfig::configure()
+    ->withPaths([
         __DIR__ . '/src',
         __DIR__ . '/tests',
+    ])
+    ->withPhpSets(true)
+    ->withRules([
     ]);
-
-    $rectorConfig->sets([
-        LevelSetList::UP_TO_PHP_83,
-    ]);
-};

src/Service/Resource/Validation/Constraint/ResourceType.php

@@ -10,7 +10,7 @@
 /**
  * @Annotation
  */
-class ResourceType extends Constraint
+#[\Attribute] class ResourceType extends Constraint
 {
     /** @var string */
     public $type;

tests/Bridge/OpenAPI/ApiTransformerTest.php

@@ -4,6 +4,8 @@
 
 namespace Undabot\SymfonyJsonApi\Tests\Bridge\OpenAPI;
 
+use PHPUnit\Framework\Attributes\CoversNothing;
+use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Yaml\Yaml;
 use Undabot\SymfonyJsonApi\Bridge\OpenApi\ApiTransformer;
@@ -16,6 +18,8 @@
  *
  * @small
  */
+#[CoversNothing]
+#[Small]
 final class ApiTransformerTest extends TestCase
 {
     private ApiTransformer $service;

tests/Bridge/OpenAPI/Helper/TypeHelperTest.php

@@ -4,6 +4,8 @@
 
 namespace Undabot\SymfonyJsonApi\Tests\Bridge\OpenAPI\Helper;
 
+use PHPUnit\Framework\Attributes\CoversNothing;
+use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Undabot\SymfonyJsonApi\Bridge\OpenApi\Helper\TypeHelper;
 
@@ -14,6 +16,8 @@
  *
  * @small
  */
+#[CoversNothing]
+#[Small]
 final class TypeHelperTest extends TestCase
 {
     public function testItResolvesBoolToBoolean(): void

tests/Bridge/OpenAPI/OpenApiGeneratorTest.php

@@ -4,6 +4,8 @@
 
 namespace Undabot\SymfonyJsonApi\Tests\Bridge\OpenAPI;
 
+use PHPUnit\Framework\Attributes\CoversNothing;
+use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Undabot\SymfonyJsonApi\Bridge\OpenApi\Model\Api;
 use Undabot\SymfonyJsonApi\Bridge\OpenApi\OpenApiDefinition;
@@ -16,6 +18,8 @@
  *
  * @small
  */
+#[CoversNothing]
+#[Small]
 final class OpenApiGeneratorTest extends TestCase
 {
     private OpenApiGenerator $service;

tests/Bridge/OpenAPI/ResourceReadSchema/ResourceReadSchemaRelationshipsTest.php

@@ -5,6 +5,8 @@
 namespace Undabot\SymfonyJsonApi\Tests\Bridge\OpenAPI\ResourceReadSchema;
 
 use Doctrine\Common\Annotations\AnnotationReader;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Undabot\SymfonyJsonApi\Bridge\OpenApi\Service\AttributeSchemaFactory;
 use Undabot\SymfonyJsonApi\Bridge\OpenApi\Service\RelationshipSchemaFactory;
@@ -17,10 +19,12 @@
 /**
  * @internal
  *
- * @covers \Undabot\SymfonyJsonApi\Bridge\OpenApi\Service\ResourceSchemaFactory
+ * @coversNothing
  *
  * @small
  */
+#[CoversClass('\Undabot\SymfonyJsonApi\Bridge\OpenApi\Service\ResourceSchemaFactory')]
+#[Small]
 final class ResourceReadSchemaRelationshipsTest extends TestCase
 {
     private ResourceSchemaFactory $resourceSchemaFactory;

tests/Bridge/OpenAPI/ResourceReadSchema/ResourceReadSchemaTest.php

@@ -5,6 +5,8 @@
 namespace Undabot\SymfonyJsonApi\Tests\Bridge\OpenAPI\ResourceReadSchema;
 
 use Doctrine\Common\Annotations\AnnotationReader;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Validator\Constraints as Assert;
 use Undabot\SymfonyJsonApi\Bridge\OpenApi\Service\AttributeSchemaFactory;
@@ -18,10 +20,12 @@
 /**
  * @internal
  *
- * @covers \Undabot\SymfonyJsonApi\Bridge\OpenApi\Service\ResourceSchemaFactory
+ * @coversNothing
  *
  * @small
  */
+#[CoversClass('\Undabot\SymfonyJsonApi\Bridge\OpenApi\Service\ResourceSchemaFactory')]
+#[Small]
 final class ResourceReadSchemaTest extends TestCase
 {
     private ResourceSchemaFactory $resourceSchemaFactory;

tests/Bridge/OpenAPI/Schema/AttributeSchemaTest.php

@@ -4,6 +4,8 @@
 
 namespace Undabot\SymfonyJsonApi\Tests\Bridge\OpenAPI\Schema;
 
+use PHPUnit\Framework\Attributes\CoversNothing;
+use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Undabot\SymfonyJsonApi\Bridge\OpenApi\Model\JsonApi\Schema\AttributeSchema;
 
@@ -14,6 +16,8 @@
  *
  * @small
  */
+#[CoversNothing]
+#[Small]
 final class AttributeSchemaTest extends TestCase
 {
     public function testItCanBeConstructedWithMinimalData(): void

tests/Integration/CreateResourceFromJsonInputTest.php

@@ -4,6 +4,8 @@
 
 namespace Undabot\SymfonyJsonApi\Tests\Integration;
 
+use PHPUnit\Framework\Attributes\CoversNothing;
+use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Undabot\JsonApi\Implementation\Encoding\PhpArrayToAttributeCollectionEncoder;
 use Undabot\JsonApi\Implementation\Encoding\PhpArrayToLinkCollectionEncoder;
@@ -22,6 +24,8 @@
  *
  * @small
  */
+#[CoversNothing]
+#[Small]
 final class CreateResourceFromJsonInputTest extends TestCase
 {
     /** @var PhpArrayToResourceEncoder */

tests/Integration/Http/Service/EventSubscriber/ViewResponseSubscriberTest.php

@@ -4,6 +4,9 @@
 
 namespace Undabot\SymfonyJsonApi\Tests\Integration\Http\Service\EventSubscriber;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Medium;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\HttpFoundation\Request;
@@ -37,10 +40,12 @@
 /**
  * @internal
  *
- * @covers \Undabot\SymfonyJsonApi\Http\Service\EventSubscriber\ViewResponseSubscriber
+ * @coversNothing
  *
- * @medium
+ * @small
  */
+#[CoversClass('\Undabot\SymfonyJsonApi\Http\Service\EventSubscriber\ViewResponseSubscriber')]
+#[Medium]
 final class ViewResponseSubscriberTest extends TestCase
 {
     private ViewResponseSubscriber $viewResponseSubscriber;
@@ -111,9 +116,7 @@ public function testBuildViewWillSetCorrectResponseWithoutLinksInEventGivenValid
         self::assertArrayNotHasKey('links', $responseContent);
     }
 
-    /**
-     * @dataProvider provideBuildViewWillSetCorrectResponseWithPaginationLinksInEventGivenValidResourceCollectionControllerWithPaginatedResultsCases
-     */
+    #[DataProvider('provideBuildViewWillSetCorrectResponseWithPaginationLinksInEventGivenValidResourceCollectionControllerWithPaginatedResultsCases')]
     public function testBuildViewWillSetCorrectResponseWithPaginationLinksInEventGivenValidResourceCollectionControllerWithPaginatedResults(
         Request $request,
         ?string $firstLink,