fix(resource model): allow meta data reading from relationship

Author: KondukterCRO

src/Model/Resource/FlatResource.php

@@ -22,12 +22,12 @@
  */
 class FlatResource
 {
-    /** @var ResourceInterface */
-    private $resource;
+    /** @var array<string,array> */
+    private array $relationshipMetas;
 
-    public function __construct(ResourceInterface $resource)
+    public function __construct(private ResourceInterface $resource)
     {
-        $this->resource = $resource;
+        $this->relationshipMetas = [];
     }
 
     /**
@@ -62,6 +62,7 @@ public function getRelationships(): array
 
         /** @var RelationshipInterface $relationship */
         foreach ($this->resource->getRelationships() as $relationship) {
+            $this->buildRelationshipMeta($relationship);
             $relationshipData = $relationship->getData();
 
             if (null === $relationshipData) {
@@ -79,6 +80,7 @@ public function getRelationships(): array
             if ($relationshipData instanceof ToOneRelationshipDataInterface && false === $relationshipData->isEmpty()) {
                 /** @var ResourceIdentifierInterface $data */
                 $data = $relationshipData->getData();
+
                 $flatRelationships[$relationship->getName()] = $data->getId();
 
                 continue;
@@ -129,4 +131,24 @@ public function getIndexedRelationshipObjects(): array
 
         return $flatRelationships;
     }
+
+    /** @return array<string,array<mixed,mixed>> */
+    public function getRelationshipMetas(): array
+    {
+        if (true === empty($this->relationshipMetas)) {
+            /** @var RelationshipInterface $relationship */
+            foreach ($this->resource->getRelationships() as $relationship) {
+                $this->buildRelationshipMeta($relationship);
+            }
+        }
+
+        return $this->relationshipMetas;
+    }
+
+    private function buildRelationshipMeta(RelationshipInterface $relationship): void
+    {
+        $this->relationshipMetas[$relationship->getName() . 'Meta'] = null === $relationship->getMeta()
+            ? []
+            : $relationship->getMeta()->getData();
+    }
 }

src/Service/Resource/Denormalizer/ResourceDenormalizer.php

@@ -18,16 +18,10 @@
 
 class ResourceDenormalizer
 {
-    /** @var ResourceMetadataFactoryInterface */
-    private $metadataFactory;
-
-    /** @var DenormalizerInterface */
-    private $denormalizer;
-
-    public function __construct(ResourceMetadataFactoryInterface $metadataFactory, DenormalizerInterface $denormalizer)
-    {
-        $this->metadataFactory = $metadataFactory;
-        $this->denormalizer = $denormalizer;
+    public function __construct(
+        private ResourceMetadataFactoryInterface $metadataFactory,
+        private DenormalizerInterface $denormalizer
+    ) {
     }
 
     /**
@@ -50,7 +44,7 @@ public function denormalize(ResourceInterface $resource, string $class): ApiMode
         try {
             /** @var ApiModel $result */
             $result = $this->denormalizer->denormalize($data, $class, null, [
-                AbstractNormalizer::ALLOW_EXTRA_ATTRIBUTES => false,
+                AbstractNormalizer::ALLOW_EXTRA_ATTRIBUTES => true,
             ]);
         } catch (MissingConstructorArgumentsException $e) {
             throw new MissingDataValueResourceDenormalizationException(
@@ -85,6 +79,7 @@ private function prepareData(ResourceInterface $resource, string $class): array
         ];
         $data = array_merge($data, $flatResource->getAttributes());
         $data = array_merge($data, $flatResource->getRelationships());
+        $data = array_merge($data, $flatResource->getRelationshipMetas());
 
         /*
          * Resource has attribute and relationship names that can be different from the property name in the class.

tests/Integration/Resource/Denormalizer/ResourceWithAliasesDenormalizerTest.php

@@ -158,7 +158,7 @@ public function testDenormalizationOfInvalidResourceResultsWithException(): void
         $this->serializer->denormalize($resource, AliasedResourceDto::class);
     }
 
-    public function testDenormalizationOfResourceWithExtraAttributeResultsWithException(): void
+    public function testDenormalizeWillReturnCorrectApiModelWithExtraAttributesIgnored(): void
     {
         $resource = new Resource(
             '1',
@@ -174,11 +174,12 @@ public function testDenormalizationOfResourceWithExtraAttributeResultsWithExcept
                 ->get()
         );
 
-        $this->expectException(ResourceDenormalizationException::class);
-        $this->serializer->denormalize($resource, AliasedResourceDto::class);
+        $model = $this->serializer->denormalize($resource, AliasedResourceDto::class);
+        static::assertInstanceOf(AliasedResourceDto::class, $model);
+        static::assertObjectNotHasAttribute('extra', $model);
     }
 
-    public function testDenormalizationOfResourceWithExtraRelationshipResultsWithException(): void
+    public function testDenormalizeWillReturnCorrectApiModelWithExtraRelationshipsIgnored(): void
     {
         $resource = new Resource(
             '1',
@@ -194,8 +195,9 @@ public function testDenormalizationOfResourceWithExtraRelationshipResultsWithExc
                 ->get()
         );
 
-        $this->expectException(ResourceDenormalizationException::class);
-        $this->serializer->denormalize($resource, AliasedResourceDto::class);
+        $model = $this->serializer->denormalize($resource, AliasedResourceDto::class);
+        static::assertInstanceOf(AliasedResourceDto::class, $model);
+        static::assertObjectNotHasAttribute('extras', $model);
     }
 
     public function testResourceWithAliasedOptionalToOneRelationshipCanBeDenormalized(): void