Skip to content

Commit

Permalink
Merge pull request #1 from unikorn-cloud/optional_class
Browse files Browse the repository at this point in the history
Make Ingress Classes Optional
  • Loading branch information
spjmurray authored Mar 13, 2024
2 parents 296485f + 96b0d3f commit a791e99
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions charts/cert-manager-issuers/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
version: v1.0.0
version: v1.0.1
name: cert-manager-issuers
description: A Helm chart to deploy default cert-manager issuers.
type: application
icon: https://raw.githubusercontent.com/eschercloudai/helm-addons/main/icons/default.png
icon: https://raw.githubusercontent.com/unikorn-cloud/unikorn/main/icons/default.png
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,7 @@ spec:
solvers:
- http01:
ingress:
class: {{ .Values.ingressClass }}
{{- with $class := .Values.ingressClass }}
ingressClassName: {{ $class }}
{{- end }}
serviceType: {{ .Values.serviceType }}
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,7 @@ spec:
solvers:
- http01:
ingress:
class: {{ .Values.ingressClass }}
{{- with $class := .Values.ingressClass }}
ingressClassName: {{ $class }}
{{- end }}
serviceType: {{ .Values.serviceType }}
2 changes: 1 addition & 1 deletion charts/cert-manager-issuers/values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Sets the ingress class of all issuers.
ingressClass: nginx
ingressClass: ~

# serviceType defines the service type to use, may be NodePort or ClusterIP
serviceType: ClusterIP

0 comments on commit a791e99

Please sign in to comment.