Add RBAC (#32)

Scoping is coming next, honest!
unikorn-cloud · Mar 27, 2024 · 7e95170 · 7e95170
1 parent 5eed23c
commit 7e95170
Show file tree

Hide file tree

Showing 19 changed files with 467 additions and 318 deletions.
diff --git a/.github/workflows/merge.yaml b/.github/workflows/merge.yaml
@@ -6,7 +6,7 @@ on:
     tags-ignore:
     - '*'
 env:
-  GO_VERSION: 1.21.1
+  GO_VERSION: 1.22.1
 jobs:
   Coverage:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml
@@ -6,7 +6,7 @@ on:
     tags-ignore:
     - '*'
 env:
-  GO_VERSION: 1.21.1
+  GO_VERSION: 1.22.1
 jobs:
   Static:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -6,7 +6,7 @@ on:
     tags:
     - '*'
 env:
-  GO_VERSION: 1.21.1
+  GO_VERSION: 1.22.1
   REGISTRY: ghcr.io
 jobs:
   release:

diff --git a/.golangci.yaml b/.golangci.yaml
@@ -29,6 +29,8 @@ linters:
   - funlen
   - predeclared
   - depguard
+  - goconst
+  - perfsprint
 linters-settings:
   gci:
     sections:

diff --git a/Makefile b/Makefile
@@ -70,10 +70,10 @@ GOBIN := $(if $(shell go env GOBIN),$(shell go env GOBIN),$(GOPATH)/bin)
 FLAGS=-trimpath -ldflags '-X $(MODULE)/pkg/constants.Version=$(VERSION) -X $(MODULE)/pkg/constants.Revision=$(REVISION)'
 
 # Defines the linter version.
-LINT_VERSION=v1.54.2
+LINT_VERSION=v1.57.1
 
 # Defines the version of the CRD generation tools to use.
-CONTROLLER_TOOLS_VERSION=v0.12.1
+CONTROLLER_TOOLS_VERSION=v0.14.0
 
 # Defines the version of code generator tools to use.
 # This should be kept in sync with the Kubenetes library versions defined in go.mod.

diff --git a/charts/unikorn/Chart.yaml b/charts/unikorn/Chart.yaml
@@ -4,7 +4,7 @@ description: A Helm chart for deploying Unikorn
 
 type: application
 
-version: v0.1.11
-appVersion: v0.1.11
+version: v0.1.12
+appVersion: v0.1.12
 
 icon: https://raw.githubusercontent.com/unikorn-cloud/unikorn/main/icons/default.png
diff --git a/charts/unikorn/crds/unikorn-cloud.org_clustermanagerapplicationbundles.yaml b/charts/unikorn/crds/unikorn-cloud.org_clustermanagerapplicationbundles.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.12.1
+    controller-gen.kubebuilder.io/version: v0.14.0
   name: clustermanagerapplicationbundles.unikorn-cloud.org
 spec:
   group: unikorn-cloud.org
@@ -32,21 +32,26 @@ spec:
     name: v1alpha1
     schema:
       openAPIV3Schema:
-        description: ClusterManagerApplicationBundle defines a bundle of applications
-          related with a particular custom resource e.g. a ClusterManager has vcluster,
-          cert-manager and cluster-api applications associated with it.  This forms
-          the backbone of upgrades by allowing bundles to be switched out in cluster
-          managers etc.
+        description: |-
+          ClusterManagerApplicationBundle defines a bundle of applications related with a particular custom
+          resource e.g. a ClusterManager has vcluster, cert-manager and cluster-api applications
+          associated with it.  This forms the backbone of upgrades by allowing bundles to be
+          switched out in cluster managers etc.
         properties:
           apiVersion:
-            description: 'APIVersion defines the versioned schema of this representation
-              of an object. Servers should convert recognized schemas to the latest
-              internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+            description: |-
+              APIVersion defines the versioned schema of this representation of an object.
+              Servers should convert recognized schemas to the latest internal value, and
+              may reject unrecognized values.
+              More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
             type: string
           kind:
-            description: 'Kind is a string value representing the REST resource this
-              object represents. Servers may infer this from the endpoint the client
-              submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+            description: |-
+              Kind is a string value representing the REST resource this object represents.
+              Servers may infer this from the endpoint the client submits requests to.
+              Cannot be updated.
+              In CamelCase.
+              More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
             type: string
           metadata:
             type: object
@@ -59,9 +64,9 @@ spec:
                 items:
                   properties:
                     name:
-                      description: Name is the name of the application.  This must
-                        match what is encoded into Unikorn's application management
-                        engine.
+                      description: |-
+                        Name is the name of the application.  This must match what is encoded into
+                        Unikorn's application management engine.
                       type: string
                     reference:
                       description: Reference is a reference to the application definition.
@@ -75,8 +80,9 @@ spec:
                           description: Name is the name of the resource we are referencing.
                           type: string
                         version:
-                          description: 'Version is the version of the application
-                            within the application type. TODO: make mandatory.'
+                          description: |-
+                            Version is the version of the application within the application type.
+                            TODO: make mandatory.
                           type: string
                       required:
                       - kind
@@ -88,15 +94,16 @@ spec:
                   type: object
                 type: array
               endOfLife:
-                description: EndOfLife marks when this bundle should not be advertised
-                  any more by Unikorn server.  It also provides a hint that users
-                  should upgrade ahead of the deadline, or that a forced upgrade should
-                  be triggered.
+                description: |-
+                  EndOfLife marks when this bundle should not be advertised any more
+                  by Unikorn server.  It also provides a hint that users should upgrade
+                  ahead of the deadline, or that a forced upgrade should be triggered.
                 format: date-time
                 type: string
               preview:
-                description: Preview indicates that this bundle is a preview and should
-                  not be used by default.
+                description: |-
+                  Preview indicates that this bundle is a preview and should not be
+                  used by default.
                 type: boolean
               version:
                 description: Version is a semantic version of the bundle, must be