Skip to content

Commit 2dc4d78

Browse files
Christina Skåre NordtømmeGitHub Enterprise
Christina Skåre Nordtømme
authored and
GitHub Enterprise
committed
Merge pull request #39 from IT-CEREBRUM/CRB-3739_extra
Finish CRB-3739 find_sko()
2 parents 384ae9d + dfa0822 commit 2dc4d78

File tree

2 files changed

+4
-13
lines changed

2 files changed

+4
-13
lines changed

Cerebrum/modules/bofhd/utils.py

+4-11
Original file line numberDiff line numberDiff line change
@@ -257,19 +257,12 @@ def get_target_disk(path):
257257
def get_target_ou_by_stedkode(stedkode):
258258
ou = Factory.get("OU")(self.db)
259259

260-
if len(stedkode) != 6 or not stedkode.isdigit():
261-
raise CerebrumError("Expected a six-digit stedkode.")
262-
263260
try:
264-
ou.find_stedkode(
265-
stedkode[0:2],
266-
stedkode[2:4],
267-
stedkode[4:6],
268-
cereconf.DEFAULT_INSTITUSJONSNR
269-
)
261+
ou.find_sko(stedkode)
262+
except ValueError:
263+
raise CerebrumError("Expected a six-digit stedkode")
270264
except Errors.NotFoundError:
271-
raise CerebrumError("Stedkode %s was not found." % stedkode)
272-
265+
raise CerebrumError("Could not find Organizational Unit with stedkode=%s" % stedkode)
273266
return ou
274267

275268
#

Cerebrum/modules/no/orgera/ou_utils.py

-2
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,6 @@ def get_ou_by_sko(db, sko):
179179
"""
180180
Fetch an OU object by stedkode
181181
"""
182-
if len(sko) != 6 or not sko.isdigit():
183-
raise ValueError('Invalid stedkode: %s' % repr(sko))
184182

185183
ou = Factory.get('OU')(db)
186184
ou.find_sko(sko)

0 commit comments

Comments
 (0)