Switch to Pyright, format with Ruff (#97)

* Fix `get_artifact_architecture()`

* Fix `get_artifact_os()`

* Specify type: ignore warning

* Upgrade harborapi

* Upgrade pydantic

* Fix `list_artifacts`

* Remove mypy dev dependency

* Exclude package init from ruff

* Add kwargs types for console functions

* Refactor `artifact vulnerability summary`

Improve type checking, declare sorting functions outside command

* Upadte pre-commit hooks

* Replace mypy with pyright

* Enable strict mode, ignore scripts

* Perform all linting and formatting with ruff

* Remove mypy configuration

* Fix all pylance strict mode errors

* Fix `replace_none()` when None is passed in

* Fix number prompt default value

Author: pederhan

.pre-commit-config.yaml

@@ -2,7 +2,7 @@
 # See https://pre-commit.com/hooks.html for more hooks
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.6.0
     hooks:
       - id: trailing-whitespace
       - id: end-of-file-fixer
@@ -14,26 +14,15 @@ repos:
   #   hooks:
   #     - id: pyupgrade
   #       args: [--py38-plus]
-  - repo: https://github.com/asottile/reorder_python_imports
-    rev: v3.10.0
-    hooks:
-      - id: reorder-python-imports
-        args: [--py38-plus, --add-import, "from __future__ import annotations"]
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: "v0.2.0"
+    rev: "v0.4.10"
     hooks:
       # Run the linter.
       - id: ruff
         args: [--fix]
       # Run the formatter.
       - id: ruff-format
-  - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: "v1.5.1"
+  - repo: https://github.com/RobertCraigie/pyright-python
+    rev: v1.1.368
     hooks:
-      - id: mypy
-        additional_dependencies: [types-all, rich]
-        language: python
-        types: [python]
-        files: '.*\.py[i]?'
-        exclude: ^tests/
-        args: [--config-file, pyproject.toml, --ignore-missing-imports]
+    - id: pyright

docs/scripts/gen_cli_data.py

@@ -4,6 +4,7 @@
 The commands are run in a limited environment (no color, limited width) to
 make the output more readable in the documentation.
 """
+
 from __future__ import annotations
 
 import os

docs/scripts/gen_cli_options.py

@@ -5,7 +5,6 @@
 from typing import NamedTuple
 
 import yaml  # type: ignore
-
 from harbor_cli.deprecation import Deprecated
 from harbor_cli.main import app
 from harbor_cli.utils.commands import get_app_callback_options

docs/scripts/gen_command_list.py

@@ -7,11 +7,9 @@
 from typing import List
 
 import yaml  # type: ignore
-
 from harbor_cli.main import app
 from harbor_cli.utils.commands import get_app_commands
 
-
 sys.path.append(Path(__file__).parent.as_posix())
 from common import DATA_DIR  # noqa
 

docs/scripts/gen_command_pages.py

@@ -1,4 +1,5 @@
 """Generate the code reference pages and navigation."""
+
 from __future__ import annotations
 
 import sys
@@ -8,11 +9,10 @@
 
 import jinja2
 import yaml  # type: ignore
-from sanitize_filename import sanitize
-
 from harbor_cli.main import app
 from harbor_cli.models import CommandSummary
 from harbor_cli.utils.commands import get_app_commands
+from sanitize_filename import sanitize
 
 sys.path.append(Path(__file__).parent.as_posix())
 sys.path.append(Path(__file__).parent.parent.parent.as_posix())

docs/scripts/gen_formats.py

@@ -4,7 +4,6 @@
 from pathlib import Path
 
 import yaml  # type: ignore
-
 from harbor_cli.format import OutputFormat
 
 sys.path.append(Path(__file__).parent.as_posix())

harbor_cli/__init__.py

@@ -3,5 +3,5 @@
 # SPDX-License-Identifier: MIT
 from __future__ import annotations
 
-from . import logs  # noreorder # configure logger first as side-effect
+from . import logs  # type: ignore # noreorder # configure logger first as side-effect
 from . import *

harbor_cli/__main__.py

@@ -2,6 +2,5 @@
 
 from .main import main
 
-
 if __name__ == "__main__":
     main()

harbor_cli/commands/api/__init__.py

@@ -1,4 +1,5 @@
 """"""
+
 from __future__ import annotations
 
 import typer