alpha release notes for 2023.3 and later fixes #31

Author: unitycoder

Diff for: UnityLauncherPro/GetUnityUpdates.cs

@@ -20,12 +20,12 @@ public static class GetUnityUpdates
         public static async Task<List<UnityVersion>> FetchAll()
         {
             var cachedVersions = LoadCachedVersions();
-            Console.WriteLine("cachedVersions: "+ cachedVersions);
+            //Console.WriteLine("cachedVersions: "+ cachedVersions);
             var latestCachedVersion = cachedVersions.FirstOrDefault();
 
-            Console.WriteLine("FetchAll "+ latestCachedVersion);
+            //Console.WriteLine("FetchAll "+ latestCachedVersion);
             var newVersions = await FetchNewVersions(latestCachedVersion);
-            Console.WriteLine("newVersions " + newVersions);
+            //Console.WriteLine("newVersions " + newVersions);
 
             var allVersions = newVersions.Concat(cachedVersions).ToList();
 
@@ -34,7 +34,7 @@ public static async Task<List<UnityVersion>> FetchAll()
                 SaveCachedVersions(allVersions);
             }
 
-            Console.WriteLine("all "+ allVersions);
+            //Console.WriteLine("all "+ allVersions);
 
             return allVersions;
         }

Diff for: UnityLauncherPro/Tools.cs

@@ -531,6 +531,7 @@ public static string GetUnityReleaseURL(string version)
 
             var cleanVersion = CleanVersionNumber(version);
             string url = $"https://unity.com/releases/editor/whats-new/{cleanVersion}#notes";
+
             //if (VersionIsArchived(version) == true)
             //{
             //    // remove f#, TODO should remove c# from china version ?
@@ -608,15 +609,17 @@ public static bool OpenReleaseNotes(string version)
         {
             bool result = false;
             if (string.IsNullOrEmpty(version)) return false;
+
             string url = null;
             if (Properties.Settings.Default.useAlphaReleaseNotes && HasAlphaReleaseNotes(version))
             {
                 url = GetAlphaReleaseNotesURL(version);
             }
             else
             {
-                url = Tools.GetUnityReleaseURL(version);
+                url = GetUnityReleaseURL(version);
             }
+
             if (string.IsNullOrEmpty(url)) return false;
 
             OpenURL(url);
@@ -847,8 +850,20 @@ public static string DownloadHTML(string url)
         public static string CleanVersionNumber(string version)
         {
             if (string.IsNullOrEmpty(version)) return null;
-            // note old patch versions still contains p## in the end
-            return Regex.Replace(version, @"[f|a|b][0-9]{1,2}", "", RegexOptions.IgnoreCase);
+
+            var split = version.Split('.');
+            float parsedVersion = float.Parse($"{split[0]}.{split[1]}");
+            // 2023.3 and newer Alpha releases, no replace
+            if (IsAlpha(version) && parsedVersion >= 2023.3)
+            {
+                // do nothing
+            }
+            else
+            {
+                // note old patch versions still contains p## in the end
+                version = Regex.Replace(version, @"[f|a|b][0-9]{1,2}", "", RegexOptions.IgnoreCase);
+            }
+            return version;
         }
 
         private static string FetchUnityVersionNumberFromHTML(string url)
@@ -2216,7 +2231,7 @@ internal static void OpenCustomAssetPath()
                 }
             }
         }
-        
+
         private static async Task<bool> DownloadFileAsync(string fileUrl, string destinationPath)
         {
             var cancellationTokenSource = new CancellationTokenSource();
@@ -2229,25 +2244,25 @@ private static async Task<bool> DownloadFileAsync(string fileUrl, string destina
                 using (var client = new HttpClient())
                 using (var response = await client.GetAsync(fileUrl, HttpCompletionOption.ResponseHeadersRead, cancellationTokenSource.Token))
                 {
-                        response.EnsureSuccessStatusCode();
+                    response.EnsureSuccessStatusCode();
 
-                        var totalBytes = response.Content.Headers.ContentLength ?? 1;
-                        var buffer = new byte[8192];
-                        var totalRead = 0;
+                    var totalBytes = response.Content.Headers.ContentLength ?? 1;
+                    var buffer = new byte[8192];
+                    var totalRead = 0;
 
-                        using (var contentStream = await response.Content.ReadAsStreamAsync())
-                        using (var fileStream = new FileStream(destinationPath, FileMode.Create, FileAccess.Write,
-                                   FileShare.None, buffer.Length, true))
+                    using (var contentStream = await response.Content.ReadAsStreamAsync())
+                    using (var fileStream = new FileStream(destinationPath, FileMode.Create, FileAccess.Write,
+                               FileShare.None, buffer.Length, true))
+                    {
+                        int bytesRead;
+                        while ((bytesRead = await contentStream.ReadAsync(buffer, 0, buffer.Length, cancellationTokenSource.Token)) > 0)
                         {
-                            int bytesRead;
-                            while ((bytesRead = await contentStream.ReadAsync(buffer, 0, buffer.Length, cancellationTokenSource.Token)) > 0)
-                            {
-                                await fileStream.WriteAsync(buffer, 0, bytesRead, cancellationTokenSource.Token);
-                                totalRead += bytesRead;
-                                progressWindow.UpdateProgress(new DownloadProgress(totalRead, totalBytes));
-                            }
-                            result = true;
+                            await fileStream.WriteAsync(buffer, 0, bytesRead, cancellationTokenSource.Token);
+                            totalRead += bytesRead;
+                            progressWindow.UpdateProgress(new DownloadProgress(totalRead, totalBytes));
                         }
+                        result = true;
+                    }
                 }
             }
             catch (TaskCanceledException)