Skip to content

Commit 8b91d53

Browse files
authored
llama : correct rms norm for llama 4 (ggml-org#12882)
1 parent 0fed24c commit 8b91d53

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/llama-model.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4440,8 +4440,8 @@ struct llm_build_llama : public llm_graph_context {
44404440

44414441
if (arch == LLM_ARCH_LLAMA4 && use_rope && hparams.use_kq_norm) {
44424442
// Llama4TextL2Norm
4443-
Qcur = ggml_rms_norm(ctx0, Qcur, 1e-6);
4444-
Kcur = ggml_rms_norm(ctx0, Kcur, 1e-6);
4443+
Qcur = ggml_rms_norm(ctx0, Qcur, hparams.f_norm_rms_eps);
4444+
Kcur = ggml_rms_norm(ctx0, Kcur, hparams.f_norm_rms_eps);
44454445
cb(Qcur, "Qcur_normed", il);
44464446
cb(Kcur, "Kcur_normed", il);
44474447
}

0 commit comments

Comments
 (0)