Skip to content

Commit 6bf0a22

Browse files
authored
Merge pull request #1486 from urbanairship/release-18.1.4
Release 18.1.4
2 parents 0b858e0 + a6334c5 commit 6bf0a22

File tree

4 files changed

+22
-4
lines changed

4 files changed

+22
-4
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22

33
[Migration Guides](https://github.com/urbanairship/android-library/tree/main/documentation/migration)
44

5+
## Version 18.1.4, July 31, 2024
6+
Patch release that includes bug fixes for Embedded Content.
7+
8+
### Changes
9+
- Fixed an issue with dismissing Embedded Content after pausing and resuming the app.
10+
- Updated the default `PreferenceCenterFragment` to scope the `PreferenceCenterViewModel` to the fragment's view lifecycle.
11+
512
## Version 18.1.3, July 30, 2024
613
Patch release that includes bug fixes for Embedded Content and Preference Center, and accessibility improvements for Message Center.
714

build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
buildscript {
22
ext {
33
// Airship Version - major.minor.patch
4-
airshipVersion = '18.1.3'
4+
airshipVersion = '18.1.4'
55

66
// Airship Version Qualifier beta, release, etc...
77
// airshipVersionQualifier = "alpha"

urbanairship-layout/src/main/java/com/urbanairship/android/layout/model/PagerModel.kt

+4-1
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,10 @@ internal class PagerModel(
403403
}
404404

405405
private fun resumeStory() {
406-
UALog.v { "resume story" }
406+
if (automatedActionsTimers.isNotEmpty()) {
407+
UALog.v { "resume story" }
408+
}
409+
407410
navigationActionTimer?.start()
408411
for (timer in automatedActionsTimers) {
409412
timer.start()

urbanairship-preference-center/src/main/java/com/urbanairship/preferencecenter/ui/PreferenceCenterFragment.kt

+10-2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ import android.widget.TextView
1010
import androidx.annotation.VisibleForTesting
1111
import androidx.fragment.app.Fragment
1212
import androidx.fragment.app.activityViewModels
13+
import androidx.fragment.app.viewModels
14+
import androidx.lifecycle.ViewModelProvider
1315
import androidx.lifecycle.lifecycleScope
1416
import androidx.lifecycle.viewModelScope
1517
import androidx.recyclerview.widget.LinearLayoutManager
@@ -78,8 +80,14 @@ public class PreferenceCenterFragment : Fragment(R.layout.ua_fragment_preference
7880
requireNotNull(arguments?.getString(ARG_ID)) { "Missing required argument: PreferenceCenterFragment.ARG_ID" }
7981
}
8082

81-
private val viewModel: PreferenceCenterViewModel by activityViewModels {
82-
PreferenceCenterViewModel.factory(preferenceCenterId)
83+
private val viewModel by lazy {
84+
ViewModelProvider(
85+
owner = this, // Scope the ViewModel to the Fragment's lifecycle.
86+
factory = PreferenceCenterViewModel.factory(preferenceCenterId)
87+
).get(
88+
key = preferenceCenterId, // Ensure we create a unique VM per pref center ID.
89+
modelClass = PreferenceCenterViewModel::class.java
90+
)
8391
}
8492

8593
@VisibleForTesting

0 commit comments

Comments
 (0)