Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hervorheben wenn Zeiteintrag von anderer Person bearbeitet wurde #1035

Open
bseber opened this issue Jan 19, 2025 · 0 comments
Open

Hervorheben wenn Zeiteintrag von anderer Person bearbeitet wurde #1035

bseber opened this issue Jan 19, 2025 · 0 comments
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. topic: timeentries type: enhancement A general enhancement
Milestone

Comments

@bseber
Copy link
Contributor

bseber commented Jan 19, 2025

Mit #206 können meine eigenen Zeiteinträge von anderen Personen bearbeitet werden.

Damit ich das sofort erkennen kann, möchte ich an Zeiteinträgen einen eindeutigen Hinweis dazu haben. Das betrifft hauptsächlich die "Zeit" Startseite auf der meine Einträge aufgelistet sind.

@bseber bseber added status: new Initial state for every issue / pullrequest type: enhancement A general enhancement labels Jan 19, 2025
@bseber bseber added this to the 2.16.0 milestone Jan 19, 2025
@github-actions github-actions bot added status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: new Initial state for every issue / pullrequest labels Jan 19, 2025
@derTobsch derTobsch modified the milestones: 2.15.1, 2.16.0 Jan 29, 2025
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Jan 29, 2025
bseber added a commit that referenced this issue Feb 14, 2025
TODOs
- [ ] ~falls relevant: auch von der "Zeit" Seite zur
Bearbeitungshistorie gelangen~
- ~[x] Auf der "Zeit" Seite einen Zeiteintrag markieren, wenn von
anderer Person bearbeitet~ (#1035)
- [x] Bearbeitungshistorie mit korrekt formatierten Informationen
anzeigen (Datum, Person, **Uhrzeit**, …)
- ~[ ] Hervorheben der geänderten Felder eines Zeiteintrags~ (#1080)
- [ ] ~Bearbeitungshistorie "alle öffnen/schließen" implementieren~
- ~[ ] Pagination für die Bearbeitungshistorie? (--> neues Ticket)~
- [x] Zeiteintrag löschen ist gerade kaputt
- ~~[ ] historisierte einträge löschen, wenn Person gelöscht wird~~
- `person` wird in dem Fall nur auf status DELETED gesetzt. Alle anderen
Daten bleiben bestehen (Aufbewahrungsfrist!). Daher löschen wir auch
keine `time_entry` und `time_entry_aud`
- [x] migration der bisher erstellten TimeEntryEntities 

Here are some things you should have thought about:

**Multi-Tenancy**
- [x] Extended new entities with `AbstractTenantAwareEntity`?
- [x] New entity added to `TenantAwareDatabaseConfiguration`?
- [x] Tested with `dev-multitenant` profile?

closes #477 

<!--

Thanks for contributing to the zeiterfassung.
Please review the following notes before submitting you pull request.

Please look for other issues or pull requests which already work on this
topic. Is somebody already on it? Do you need to synchronize?

# Security Vulnerabilities

🛑 STOP! 🛑 If your contribution fixes a security vulnerability, please do
not submit it.
Instead, please write an E-Mail to [email protected] with all the
information
to recreate the security vulnerability.

# Describing Your Changes

If, having reviewed the notes above, you're ready to submit your pull
request, please
provide a brief description of the proposed changes.

If they:
🐞 fix a bug, please describe the broken behaviour and how the changes
fix it.
    Please label with 'type: bug' and 'status: new'
    
🎁 make an enhancement, please describe the new functionality and why you
believe it's useful.
    Please label with 'type: enhancement' and 'status: new'
 
If your pull request relates to any existing issues,
please reference them by using the issue number prefixed with #.

-->
@derTobsch derTobsch modified the milestones: 2.16.0, 2.17.0 Feb 21, 2025
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. topic: timeentries type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants