Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usb4java/usb4java-javax#8 improvements #9

Closed
wants to merge 1 commit into from

Conversation

SKART1
Copy link

@SKART1 SKART1 commented May 13, 2016

#8 try to fix

@kayahr
Copy link
Member

kayahr commented Oct 21, 2018

Thanks for your contribution but I have to decline this PR. Changing the visibility of classes or methods is not an option here because this breaks the compatibility to the javax.usb spec. An application which uses the javax-usb API of usb4java must also work with any other javax.usb implementation by just setting a different class name in the properties file. If the application relies on some internal usb4java-specific APIs then this can't work. That's why these classes are package private. And I'm not going to change this.

The problem with the wrong port numbers must be fixed somehow else. Currently usb4java-javax uses dynamically generated virtual port numbers. I'm not sure why I did this, maybe the first libusb version which I used didn't provide port numbers. Now I guess the code could be refactored to use the port numbers provided by libusb.

@kayahr kayahr closed this Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants