Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property description and tags not restored from saved project #618

Closed
kyao opened this issue Aug 25, 2021 · 8 comments
Closed

Property description and tags not restored from saved project #618

kyao opened this issue Aug 25, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@kyao
Copy link
Collaborator

kyao commented Aug 25, 2021

Property description and tags are not restored from saved project. The same thing happens for apply annotations. The project description and tags are lost as well.

To replicate:

  • load education index dataset
  • click on suggest annotation
  • click on cell A2 and create the property
  • click on cell A2 again to 1) add property description and 2) define some tags
  • download .t2wmlz project file
    When restoring this project file, cell A2 is highlighted yellow as property. But, clicking on it the description is missing. And, clicking on the show property tags button brings the popup window in a strange state.
@kyao kyao added the bug Something isn't working label Aug 25, 2021
@kyao kyao assigned devowit and g1eb Aug 25, 2021
@devowit
Copy link
Contributor

devowit commented Aug 25, 2021

when doing copy annotation we expect to copy properties as they are?

@kyao
Copy link
Collaborator Author

kyao commented Aug 25, 2021

Yes, the properties should stay the same

@g1eb
Copy link
Contributor

g1eb commented Sep 1, 2021

Property description is either not exported with .t2wmlz files or not restored to what it was before.

For the property tags I've added a workaround as described in this comment: #623 (comment)

@devowit
Copy link
Contributor

devowit commented Sep 3, 2021

i have fixed this for loading projects, it is merged to development

@kyao , isn't the goal of copying annotations copying the structure? can't the property change between copies, ie in one sheet it's "education level" and in another it's "average score"? in such a case copying the properties over would generate wrong results....

@devowit
Copy link
Contributor

devowit commented Sep 12, 2021

@kyao, should i copy properties with annotations always, or not?

@kyao
Copy link
Collaborator Author

kyao commented Sep 29, 2021

fixed

@kyao kyao closed this as completed Sep 29, 2021
@kyao kyao reopened this Sep 29, 2021
@devowit
Copy link
Contributor

devowit commented Sep 30, 2021

note: this has specifically been reopened because currently, applying an existing annotation does not copy that annotation's properties.

@devowit
Copy link
Contributor

devowit commented Sep 30, 2021

so I'm closing this in favor of #642 which is clearer

@devowit devowit closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants