Skip to content
This repository was archived by the owner on May 16, 2022. It is now read-only.

Commit f1174e4

Browse files
author
Jan Koscielniak
committed
Fix pytest fixture warnings
1 parent a54333e commit f1174e4

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/test_bot.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,20 @@ def multiple_release_issues(self):
7272
self.g_utils.open_issue("0.0.1 release")
7373
self.g_utils.open_issue("0.0.2 release")
7474

75-
@pytest.fixture()
7675
def open_pr(self):
7776
"""Opens two release issues in a repository"""
7877
conf = yaml.safe_load(RELEASE_CONF) or {}
7978
self.release_bot.new_release.update(conf)
80-
self.open_issue()
79+
self.g_utils.open_issue("0.0.1 release")
8180
self.release_bot.find_open_release_issues()
8281
self.release_bot.make_release_pull_request()
8382
pr_number = self.release_bot.github.pr_exists("0.0.1 release")
8483
assert pr_number and self.g_utils.merge_pull_request(pr_number)
8584

85+
@pytest.fixture()
86+
def open_pr_fixture(self):
87+
self.open_pr()
88+
8689
@pytest.fixture()
8790
def github_release(self):
8891
"""Setups environment for releasing on Github"""
@@ -124,7 +127,7 @@ def test_pr_from_issue(self, open_issue):
124127
assert self.release_bot.make_release_pull_request()
125128
assert self.release_bot.github.pr_exists("0.0.1 release")
126129

127-
def test_github_release(self, open_pr):
130+
def test_github_release(self, open_pr_fixture):
128131
"""Tests releasing on Github"""
129132
assert self.release_bot.find_newest_release_pull_request()
130133
self.release_bot.make_new_github_release()

0 commit comments

Comments
 (0)