Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic CKB fee rate when send CKB transactions. #18

Open
yangby-cryptape opened this issue Apr 3, 2024 · 2 comments · Fixed by #17
Open

Support dynamic CKB fee rate when send CKB transactions. #18

yangby-cryptape opened this issue Apr 3, 2024 · 2 comments · Fixed by #17
Labels
enhancement New feature or request P-Low

Comments

@yangby-cryptape
Copy link
Contributor

yangby-cryptape commented Apr 3, 2024

References

  • A suboptimal implementation.

    I have been suggestion, that to use the median fee rate which is fetched through the CKB RPC method get_fee_rate_statistics as the dynamic CKB fee rate to send CKB transactions.

    But after few days test, I found some issues of this implementation.

    If someone sent a large-fee transaction, even all blocks are nearly empty, 1000 is enough, the dynamic fee rate API will still return a large number.

    A better solution is required.

@Flouse Flouse linked a pull request Apr 4, 2024 that will close this issue
@EthanYuan
Copy link
Collaborator

EthanYuan commented May 21, 2024

@Flouse Flouse added the P-Low label May 21, 2024
@Flouse
Copy link
Contributor

Flouse commented Jan 12, 2025

Some thoughts about the implementation of a dynamic fee rate feature for the SPV updater:

Requirements

  1. The SPV updater should automatically adjust the fee rate based on current network congestion.
  2. Include options for service maintainers to set minimum and maximum fee thresholds.
  3. Provide logging for fee adjustments made by the updater.
  4. Ensure compatibility with existing transaction processing workflows.

References

@Flouse Flouse added the enhancement New feature or request label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P-Low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants