Skip to content

Commit 6b2a56b

Browse files
committed
WIP: fixing tests
1 parent 180681e commit 6b2a56b

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

migrations/migration.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ def dfs(node):
4242
for filename in migration_files:
4343
curr_migration = filename[:-3]
4444
prev_migration = self.get_previous_migration_id(filename)
45-
46-
if prev_migration is not None:
47-
migration_sequence[curr_migration] = prev_migration
45+
migration_sequence[curr_migration] = prev_migration
4846

4947
# Perform DFS from each node
5048
for node in migration_sequence:

tests/migration_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
@pytest.fixture
77
def migration_instance():
8-
return Migration(os.path.dirname(__file__))
8+
return Migration()
99

1010
@pytest.fixture
1111
def mock_get_previous_migration_id():
@@ -26,8 +26,8 @@ def test_build_migration_sequence_empty(mock_get_previous_migration_id):
2626

2727
def test_build_migration_sequence_with_dependencies(mock_get_previous_migration_id):
2828
# Mock the output of get_migration_files
29-
fake_filenames = ['migration1.py', 'migration2.py', 'migration3.py']
30-
with patch.object(Migration, 'get_migration_files', return_value=fake_filenames):
29+
mock_filenames = ['migration1.py', 'migration2.py', 'migration3.py']
30+
with patch.object(Migration, 'get_migration_files', return_value=mock_filenames):
3131
# Mock the output of get_previous_migration_id
3232
mock_get_previous_migration_id.side_effect = {
3333
'migration2.py': 'migration1',
@@ -47,8 +47,8 @@ def test_build_migration_sequence_with_dependencies(mock_get_previous_migration_
4747

4848
def test_build_migration_sequence_with_circular_dependency(mock_get_previous_migration_id):
4949
# Mock the output of get_migration_files
50-
fake_filenames = ['migration1.py', 'migration2.py']
51-
with patch.object(Migration, 'get_migration_files', return_value=fake_filenames):
50+
mock_filenames = ['migration1.py', 'migration2.py']
51+
with patch.object(Migration, 'get_migration_files', return_value=mock_filenames):
5252
# Mock the output of get_previous_migration_id to create circular dependency
5353
mock_get_previous_migration_id.side_effect = {
5454
'migration2.py': 'migration1',

0 commit comments

Comments
 (0)