Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patient issue list to reflect new reports #465

Closed
7 tasks done
johnny2smooth opened this issue Sep 7, 2022 · 0 comments · Fixed by #467
Closed
7 tasks done

Fix patient issue list to reflect new reports #465

johnny2smooth opened this issue Sep 7, 2022 · 0 comments · Fixed by #467

Comments

@johnny2smooth
Copy link
Collaborator

johnny2smooth commented Sep 7, 2022

Description

This to-do was raised to make sure that patient issue data was being updated more often than daily, if a patient ended up having an issue after the initial list was created resolved.

To-do

  • Modify alreadyReviewed logic on front end to further specify requirements
  • instead of checking wasToday we can check that this last general resolution was created after their last report.
  • Add logic (+maybe other checks) to verify there aren't any new reports since last general resolution
  • Sync up logic with current components and
  • unresolvedReports.createdAt time is not changing! even when a new update + message is made
  • Reviewed patient with initial problem repopulates to unreviewed upon reload.
  • Rename ^^ and refactor

Screenshots

Upon patient resolution, the resolutions API is updated. It is being sent twice as an OPTIONS and a POST method.

Image

Notice here how there is no API request to update the list of patient_issues.

When this page is reloaded, we see that all of the original patient_issues data is being sent. None of the previous interactions have changed its shape.

Image

I am curious as to how the page knows how to not render all the issues from the API

New understanding

@johnny2smooth johnny2smooth linked a pull request Sep 29, 2022 that will close this issue
@johnny2smooth johnny2smooth removed a link to a pull request Sep 29, 2022
@johnny2smooth johnny2smooth linked a pull request Sep 29, 2022 that will close this issue
@johnny2smooth johnny2smooth removed a link to a pull request Sep 29, 2022
@johnny2smooth johnny2smooth linked a pull request Sep 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant