Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use user mentions instead of tags in coin leaderboard #518

Merged
merged 1 commit into from
May 16, 2024
Merged

use user mentions instead of tags in coin leaderboard #518

merged 1 commit into from
May 16, 2024

Conversation

hyperneutrino
Copy link

Summary of Changes

  • change the coin leaderboard to display user mentions instead of tags

Motivation and Explanation

  • user mentions look nicer
  • allow mentioning users on the leaderboard even if the user cannot be fetched for some reason

Related Issues

Steps to Reproduce

  • use /coin leaderboard

Demonstration of Changes

Before

image

After

image

Fan-Yang-284
Fan-Yang-284 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Fan-Yang-284 Fan-Yang-284 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyperneutrino hyperneutrino merged commit d2257b9 into main May 16, 2024
2 checks passed
@hyperneutrino hyperneutrino deleted the hyper/517/use-mentions-in-leaderboard branch May 16, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fan-Yang-284 Fan-Yang-284 Fan-Yang-284 approved these changes

@probro27 probro27 Awaiting requested review from probro27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use user mentions in CodeyCoin Leaderboard instead of usernames
2 participants
@hyperneutrino @Fan-Yang-284