Skip to content

Commit 362c1da

Browse files
refactor: make selected property in ListMixin use sync: true (#8594) (#8601)
Co-authored-by: Serhii Kulykov <[email protected]>
1 parent f46680f commit 362c1da

File tree

7 files changed

+8
-6
lines changed

7 files changed

+8
-6
lines changed

packages/a11y-base/src/list-mixin.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export const ListMixin = (superClass) =>
4040
type: Number,
4141
reflectToAttribute: true,
4242
notify: true,
43+
sync: true,
4344
},
4445

4546
/**

packages/a11y-base/test/list-mixin.test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -774,7 +774,6 @@ const runTests = (defineHelper, baseMixin) => {
774774

775775
it('should reset previously selected item when listbox and items are disabled', async () => {
776776
list.selected = 3;
777-
await nextUpdate(list);
778777
expect(items[3].selected).to.be.true;
779778

780779
list.disabled = true;
@@ -788,7 +787,6 @@ const runTests = (defineHelper, baseMixin) => {
788787

789788
it('should restore previously selected item when listbox becomes re-enabled', async () => {
790789
list.selected = 3;
791-
await nextUpdate(list);
792790

793791
list.disabled = true;
794792
items.forEach((item) => {

packages/item/src/vaadin-item-mixin.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export const ItemMixin = (superClass) =>
3838
value: false,
3939
reflectToAttribute: true,
4040
observer: '_selectedChanged',
41+
sync: true,
4142
},
4243

4344
/** @private */

packages/select/src/vaadin-select-base-mixin.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export const SelectBaseMixin = (superClass) =>
9797
value: '',
9898
notify: true,
9999
observer: '_valueChanged',
100+
sync: true,
100101
},
101102

102103
/**
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import '@vaadin/item/vaadin-lit-item.js';
2+
import '@vaadin/list-box/vaadin-lit-list-box.js';
13
import './not-animated-styles.js';
24
import '../src/vaadin-lit-select.js';
35
import './select.common.js';
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import '@vaadin/item/vaadin-item.js';
2+
import '@vaadin/list-box/vaadin-list-box.js';
13
import './not-animated-styles.js';
24
import '../src/vaadin-select.js';
35
import './select.common.js';

packages/select/test/select.common.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ import {
1414
tab,
1515
} from '@vaadin/testing-helpers';
1616
import sinon from 'sinon';
17-
import '@vaadin/item/vaadin-item.js';
18-
import '@vaadin/list-box/vaadin-list-box.js';
1917
import { html, render } from 'lit';
2018

2119
describe('vaadin-select', () => {
@@ -755,7 +753,6 @@ describe('vaadin-select', () => {
755753

756754
beforeEach(async () => {
757755
select = fixtureSync(`<vaadin-select value="v2"></vaadin-select>`);
758-
await nextRender();
759756
select.renderer = (root) => {
760757
render(
761758
html`
@@ -767,8 +764,8 @@ describe('vaadin-select', () => {
767764
root,
768765
);
769766
};
767+
await nextRender();
770768
valueButton = select.querySelector('vaadin-select-value-button');
771-
await nextUpdate(select);
772769
menu = select._menuElement;
773770
});
774771

0 commit comments

Comments
 (0)