Skip to content

Commit 4fd545d

Browse files
authoredMar 26, 2025··
fixing github integration tests (#76)
* fixing github integration tests Signed-off-by: yairgott <yairgott@gmail.com> * fixing github grouping Signed-off-by: yairgott <yairgott@gmail.com> --------- Signed-off-by: yairgott <yairgott@gmail.com>
1 parent 2b055c9 commit 4fd545d

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed
 

‎.github/workflows/integration_tests.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
workflow_dispatch: # allow manual triggering
1111

1212
concurrency:
13-
group: clang-${{ github.head_ref || github.ref }}
13+
group: integration-tests-${{ github.head_ref || github.ref }}
1414
cancel-in-progress: true
1515

1616
jobs:
@@ -31,4 +31,4 @@ jobs:
3131
run: docker build -t presubmit-image -f .devcontainer/Dockerfile .
3232

3333
- name: Run Tests
34-
run: docker run --rm -v "$(pwd):/workspace" --user "ubuntu:ubuntu" presubmit-image sudo ./build.sh --run-integration-tests --test-errors-stdout
34+
run: docker run --privileged --rm -v "$(pwd):/workspace" --user "ubuntu:ubuntu" presubmit-image sudo ./build.sh --run-integration-tests --test-errors-stdout

‎.github/workflows/unittests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
workflow_dispatch: # allow manual triggering
1111

1212
concurrency:
13-
group: clang-${{ github.head_ref || github.ref }}
13+
group: unittests-${{ github.head_ref || github.ref }}
1414
cancel-in-progress: true
1515

1616
jobs:

‎testing/valkey_search_test.cc

+6-4
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
#include "src/utils/string_interning.h"
5050
#include "testing/common.h"
5151
#include "testing/coordinator/common.h"
52+
#include "vmsdk/src/memory_allocation.h"
5253
#include "vmsdk/src/module.h"
5354
#include "vmsdk/src/testing_infra/module.h"
5455
#include "vmsdk/src/testing_infra/utils.h"
@@ -282,10 +283,11 @@ TEST_P(LoadTest, load) {
282283
.WillRepeatedly(testing::Return(0));
283284
}
284285
vmsdk::module::Options options;
285-
EXPECT_EQ(vmsdk::module::OnLoadDone(ValkeySearch::Instance().OnLoad(
286-
&fake_ctx_, args.data(), args.size()),
287-
&fake_ctx_, options),
288-
test_case.expected_load_ret);
286+
auto load_res = vmsdk::module::OnLoadDone(
287+
ValkeySearch::Instance().OnLoad(&fake_ctx_, args.data(), args.size()),
288+
&fake_ctx_, options);
289+
vmsdk::ResetValkeyAlloc();
290+
EXPECT_EQ(load_res, test_case.expected_load_ret);
289291
auto writer_thread_pool = ValkeySearch::Instance().GetWriterThreadPool();
290292
auto reader_thread_pool = ValkeySearch::Instance().GetReaderThreadPool();
291293
if (test_case.expect_thread_pool_started) {

0 commit comments

Comments
 (0)
Please sign in to comment.