Testing + Basic Bugs Resolved

Author: farissimran

package.json

@@ -97,10 +97,12 @@
     "protractor": "~7.0.0",
     "rimraf": "2.6.2",
     "rxjs": "^6.6.7",
+    "rxjs-tslint-rules": "4.34.8",
     "shelljs": "0.7.8",
     "systemjs-builder": "0.16.12",
     "ts-node": "3.3.0",
     "tslint": "~6.1.0",
+    "tslint-config-valorsoft": "2.1.1",
     "typescript": "^4.9.5",
     "uuid": "3.1.0",
     "webpack": "3.8.1",

src/demo/app/app.component.ts

@@ -274,7 +274,7 @@ export class AppComponent implements OnInit {
     ]
   };
 
-  @ViewChild('treeFonts', { static: true })
+  @ViewChild('treeFonts', { static: false })
   public treeFonts;
 
   public pls: TreeModel;
@@ -504,7 +504,7 @@ export class AppComponent implements OnInit {
   };
   private lastFFSNodeId = 86;
 
-  @ViewChild('treeFFS', { static: true })
+  @ViewChild('treeFFS', { static: false })
   public treeFFS;
 
   public icons: TreeModel = {
@@ -611,7 +611,7 @@ export class AppComponent implements OnInit {
     AppComponent.logEvent(e, 'Created');
   }
 
-  public onNodeFFSCreated(e: NodeEvent, controller): void {
+  public onNodeFFSCreated(e: NodeEvent, controller?): void {
     AppComponent.logEvent(e, 'Created');
     if (controller) {
       controller.changeNodeId(++this.lastFFSNodeId);

src/demo/polyfills.ts

@@ -49,3 +49,4 @@ import 'zone.js'; // Included with Angular CLI.
  * Needed for: All but Chrome, Firefox, Edge, IE11 and Safari 10
  */
 // import 'intl';  // Run `npm install --save intl`.
+(window as any).global = window;

src/menu/node-menu.component.ts

@@ -23,7 +23,7 @@ export class NodeMenuComponent implements OnInit, OnDestroy {
 
   @Input() public menuItems: NodeMenuItem[];
 
-  @ViewChild('menuContainer', { static: true })
+  @ViewChild('menuContainer', { static: false })
   public menuContainer: any;
 
   public availableMenuItems: NodeMenuItem[] = [

src/tree-internal.component.ts

@@ -99,7 +99,7 @@ export class TreeInternalComponent implements OnInit, OnChanges, OnDestroy, Afte
   public isReadOnly = false;
   public controller: TreeController;
 
-  @ViewChild('checkbox', { static: true })
+  @ViewChild('checkbox', { static: false })
   public checkboxElementRef: ElementRef;
 
   private subscriptions: Subscription[] = [];

src/tree.component.ts

@@ -61,10 +61,10 @@ export class TreeComponent implements OnInit, OnChanges, OnDestroy {
 
   public tree: Tree;
 
-  @ViewChild('rootComponent', { static: true })
+  @ViewChild('rootComponent', { static: false })
   public rootComponent;
 
-  @ContentChild(TemplateRef, { static: true })
+  @ContentChild(TemplateRef, { static: false })
   public template;
 
   private subscriptions: Subscription[] = [];

test/tree-controller.spec.ts

@@ -55,7 +55,7 @@ class TestComponent {
   public settings = new Ng2TreeSettings();
   public treeLord: TreeModel = treeLord;
 
-  @ViewChild('lordTreeInstance', { static: true })
+  @ViewChild('lordTreeInstance', { static: false })
   public lordTreeComponent;
 
   public constructor(public treeHolder: ElementRef) {