Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measure_get_meas() does not return all data #73

Open
gregbodine opened this issue Oct 14, 2021 · 3 comments
Open

measure_get_meas() does not return all data #73

gregbodine opened this issue Oct 14, 2021 · 3 comments

Comments

@gregbodine
Copy link

it looks like commit 02a3164 has changed the defaults for startdate, enddate and lastupdate from None to utcnow(). So, if I you don't provide these optional arguments then you will only get data from today. The only way around this is to set each of these arguments to None in the function call, which does not make much sense. Also startdate and enddate should be mutually exclusive from lastupdate if I read the official doc correctly. with this commit all three are set in the params of the rest call with the default value of utcnow(). When I change these Optional arguments defaults back to None within the code, then things started working again as expected.

@msexton187
Copy link

I was having the same issue. I couldn't get any measurement data until I updated the code to None as you suggested. Thanks for figuring that out. I would never have found it.

@signebedi
Copy link

I'll second the above. Explicitly passing None for the lastupdate param when using startdate and enddate fixed this problem for me. Would be worth adding this behavior to a method docstring or comment so future users can solve this problem. Or... revert back the None default value, at least for lastupdate, and set startdate to utcnow - 1 day or something...

@mattppal
Copy link

+1, this had me puzzled for quite some time. Thanks for posting this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants