Change return format of images with properties

vasokot · Nov 22, 2024 · d5ebfec · d5ebfec
1 parent 5971ced
commit d5ebfec
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,7 +23,7 @@ jobs:
 
       - name: Restore virtualenv from cache
         id: cache
-        uses: actions/cache@v1
+        uses: actions/cache@v3
         with:
           path: ~/.cache/pypoetry/virtualenvs
           key: poetry-${{ hashFiles('poetry.lock') }}

diff --git a/jira2markdown/markup/images.py b/jira2markdown/markup/images.py
@@ -32,7 +32,7 @@ def action(self, tokens: ParseResults) -> str:
             if name in self.ALLOWED_ATTRS
         )
         if attrs_str:
-            return f'<img src="{tokens.url}" {attrs_str} />'
+            return f"![{tokens.url}]({tokens.url})" + "{" + attrs_str + "}"
         else:
             return f"![{tokens.url}]({tokens.url})"
 

diff --git a/tests/markup/test_images.py b/tests/markup/test_images.py
@@ -21,6 +21,6 @@ def test_url_line_break(self):
         assert convert("!http://example.\ncom/image.png!") == "!http://example.\ncom/image.png!"
 
     def test_image_attributes(self):
-        assert convert("!image.jpg|width=300!") == '<img src="image.jpg" width="300" />'
-        assert convert("!image.jpg| WIDTH  =  300 , HEIGHT=200!") == '<img src="image.jpg" width="300" height="200" />'
+        assert convert("!image.jpg|width=300!") == '![image.jpg](image.jpg){width="300"}'
+        assert convert("!image.jpg| WIDTH  =  300 , HEIGHT=200!") == '![image.jpg](image.jpg){width="300" height="200"}'
         assert convert("!image.jpg|align=right, vspace=4!") == "![image.jpg](image.jpg)"
diff --git a/tests/markup/test_mixed_content.py b/tests/markup/test_mixed_content.py
@@ -258,7 +258,7 @@ def test_basic_markup(self):
         )
 
     def test_cell_image(self):
-        assert convert("|!image.png|width=300!") == '|<img src="image.png" width="300" />|\n|---|\n'
+        assert convert("|!image.png|width=300!") == '|![image.png](image.png){width="300"}|\n|---|\n'
 
     def test_cell_link(self):
         assert convert("|[link|http://example.com]|") == "|[link](http://example.com)|\n|---|\n"
@@ -285,7 +285,7 @@ def test_text_formatting(self):
             == """
 > **My Title**
 > a block of text surrounded with a **panel**
-> line with <img src="image.png" width="300" />
+> line with ![image.png](image.png){width="300"}
 """
         )