add clusterOI panel ui test

Author: daniel-ji

src/clustersOfInterest.js

@@ -1008,7 +1008,7 @@ function _action_drop_down(self, pg) {
 
   if (!self._is_CDC_executive_mode) {
     dropdown.push({
-      label: "Clone this cluster of interest in a new editor pane",
+      label: "Clone this cluster of interest in a new editor panel",
       action: function (button, value) {
         let ref_set = self.priority_groups_find_by_name(pg.name);
         let copied_node_objects = _.clone(ref_set.node_objects);
@@ -1418,6 +1418,7 @@ function draw_priority_set_table(self, container, priority_groups) {
           0,
           {
             icon: "fa-info-circle",
+            classed: { "view-edit-cluster": true },
             help: "View/edit this cluster of interest",
             dropdown: _action_drop_down(self, pg),
             /*action: function (button, menu_value) {

ui-tests/clusterOI.spec.js

@@ -18,6 +18,21 @@ test.afterEach(({ page }) => {
   expect(errors).toEqual([]);
 });
 
+/**
+ * Returns a function that accepts a dialog and conditionally dismisses it
+ * @param {*} message message that the dialog should contain to be dismissed
+ * @returns function that accepts a dialog and dismisses it if the message matches
+ */
+const getAcceptDialogFunction = (message) => {
+  return async (dialog) => {
+    if (dialog.message().includes(message)) {
+      await dialog.accept();
+    } else {
+      await dialog.dismiss();
+    }
+  }
+}
+
 const openEditor = async (page) => {
   // go to clusterOI tab
   await expect(page.locator("#priority-set-tab")).toBeVisible();
@@ -35,8 +50,10 @@ const openEditor = async (page) => {
   await expect(jsPanels).toHaveLength(1);
 }
 
-const createCluster = async (page, nodes) => {
-  await openEditor(page);
+const createCluster = async (page, nodes, editorOpen = false) => {
+  if (!editorOpen) {
+    await openEditor(page);
+  }
 
   for (const node of nodes) {
     await page.locator('[data-hivtrace-ui-role="priority-panel-nodeids"]').fill(node);
@@ -64,12 +81,21 @@ const previewClusterOI = async (page) => {
  * Assumes that the clusterOI editor has nodes
  * Assumes that a current clusterOI does not have the same name
  */
-const saveClusterOI = async (page, name) => {
+const saveClusterOI = async (page, name, expectDialog = false) => {
   await page.locator("#priority-panel-save").click();
   await expect(page.locator(".has-error")).toBeVisible();
 
   await page.locator('[data-hivtrace-ui-role="priority-panel-name"]').fill(name);
-  await page.locator("#priority-panel-save").click();
+
+  if (expectDialog) {
+    const acceptDialog = getAcceptDialogFunction("This cluster of interest does not include all the nodes in the current");
+    await page.on('dialog', acceptDialog);
+    await page.locator("#priority-panel-save").click();
+    await page.off('dialog', acceptDialog);
+  } else {
+    await page.locator("#priority-panel-save").click();
+  }
+
   await expect(page.locator(".has-error")).toHaveCount(0);
 
   // jspanel should not be visible
@@ -87,18 +113,7 @@ const saveClusterOI = async (page, name) => {
 test('clusterOI editor opens, can add nodes', async ({ page }) => {
   // these specific nodes cause a confirm to appear when trying to save the clusterOI  
   await createCluster(page, ["BMK384750US2015", "BMK385560US2007"]);
-
-  const acceptDialog = async (dialog) => {
-    if (dialog.message().includes("This cluster of interest does not include all the nodes in the current")) {
-      await dialog.accept();
-    } else {
-      await dialog.dismiss();
-    }
-  }
-
-  await page.on('dialog', acceptDialog);
-  await saveClusterOI(page, "Cluster 1");
-  await page.off('dialog', acceptDialog);
+  await saveClusterOI(page, "Cluster 1", true);
 });
 
 test('preview cluster and then open clusterOI editor', async ({ page }) => {
@@ -128,4 +143,59 @@ test('add nodes via graph to clusterOI editor and save', async ({ page }) => {
   await previewClusterOI(page);
 
   await saveClusterOI(page, "Cluster 1");
-});
+});
+
+test('add nodes via graph to clusterOI editor, save, clone clusterOI, save, and delete all', async ({ page }) => {
+  // add nodes via graph to clusterOI editor and save
+  await openEditor(page);
+
+  await page.locator("#trace-default-tab").click();
+  await page.locator(".cluster-group").first().click();
+  await page.getByText("Add this cluster to the cluster of interest", { exact: true }).click();
+
+  await previewClusterOI(page);
+
+  await saveClusterOI(page, "Cluster 1");
+
+  // clone clusterOI and save
+  await page.locator(".view-edit-cluster").first().click();
+  await page.getByText("Clone this cluster of interest in a new editor panel", { exact: true }).click();
+
+  const jsPanels = await page.locator(".jsPanel").all();
+  await expect(jsPanels).toHaveLength(1);
+
+  await createCluster(page, ["01_AEMK272426TH2015"], true);
+
+  await saveClusterOI(page, "Cluster 2", true);
+
+  await expect(await page.locator("#priority_set_table")
+    .filter({ has: page.getByText("Cluster 1") })
+    .filter({ has: page.getByText("Cluster 2") }))
+    .toBeVisible();
+
+  // delete all clusters, accept confirmation dialog
+  await page.locator(".view-edit-cluster").first().click();
+  const acceptDialog = getAcceptDialogFunction("This action cannot be undone. Proceed?")
+  await page.on('dialog', acceptDialog);
+  await page.getByText("Delete this cluster of interest", { exact: true }).first().click();
+  await page.off('dialog', acceptDialog);
+
+  await expect(await page.locator("#priority_set_table")
+    .filter({ has: page.getByText("Cluster 1") })
+    .filter({ has: page.getByText("Cluster 2") }))
+    .toHaveCount(0);
+
+  await expect(await page.locator("#priority_set_table")
+    .filter({ has: page.getByText("Cluster 2") }))
+    .toHaveCount(1);
+
+  // delete the last cluster
+  await page.locator(".view-edit-cluster").first().click();
+  const acceptDialog2 = getAcceptDialogFunction("This action cannot be undone. Proceed?")
+  await page.on('dialog', acceptDialog2);
+  await page.getByText("Delete this cluster of interest", { exact: true }).first().click();
+  await page.off('dialog', acceptDialog2);
+
+  await expect(await page.locator("#priority_set_table tbody tr"))
+    .toHaveCount(0);
+})