Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Puppet 4 language features #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reidmv
Copy link

@reidmv reidmv commented Nov 8, 2016

Also cleans up the bitmask stuff a bit.

@reidmv
Copy link
Author

reidmv commented Nov 8, 2016

James, I think this module doesn't work. The problem is that the Puppet agent runs Powershell in the SYSTEM context, not a user context, so trying to set HKCU hive keys won't work. Has this ever worked for you?

Regardless, this PR should preserve the existing behavior while making it a little easier to read and tell what's going on. Will make Puppet 4 required for types and heredocs.

Also cleans up the bitmask stuff a bit
@velocity303
Copy link
Owner

@reidmv - Yes, this module does seem to have issues when running as a service, but did previously work fine when executed as a user from the command prompt. Based on what you have noted, I'm not sure this method will be able to be used as a right solution but may make managing a Windows workstation for a local user to control their settings a bit easier. I'll give this pull request a run-through and let you know if it works fine for me.

@velocity303
Copy link
Owner

@reidmv It looks like the new language features work, but even local application by a user no longer functions as it did in the 3.x days when this was developed. As such I'm going to hold off on the pull request until a reasonable workaround can be found. There is potential that functionally similar registry keys could be found within HKLM which would allow for this management to be done in a more maintainable manner. If HKLM provides the appropriate keys, I could potentially manage this setting with the official registry module. I will research this and update accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants