fix: ignore metadata from default.js

huozhi · huozhi · commit c071f53ae4b0 · 2025-02-05T13:28:14.000+01:00
diff --git a/packages/next/src/lib/metadata/resolve-metadata.ts b/packages/next/src/lib/metadata/resolve-metadata.ts
@@ -51,7 +51,7 @@ import {
 import { resolveIcons } from './resolvers/resolve-icons'
 import { getTracer } from '../../server/lib/trace/tracer'
 import { ResolveMetadataSpan } from '../../server/lib/trace/constants'
-import { PAGE_SEGMENT_KEY } from '../../shared/lib/segment'
+import { DEFAULT_SEGMENT_KEY, PAGE_SEGMENT_KEY } from '../../shared/lib/segment'
 import * as Log from '../../build/output/log'
 import type { WorkStore } from '../../server/app-render/work-async-storage.external'
 import type {
@@ -443,6 +443,10 @@ async function collectMetadata({
   const hasErrorConventionComponent = Boolean(
     errorConvention && tree[2][errorConvention]
   )
+  // If it's default.js, ignore the metadata
+  if (tree[0] === DEFAULT_SEGMENT_KEY) {
+    return
+  }
   if (errorConvention) {
     mod = await getComponentTypeModule(tree, 'layout')
     modType = errorConvention
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/layout.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/layout.tsx
@@ -0,0 +1,19 @@
+import Link from 'next/link'
+import React from 'react'
+
+export default function Root({ children }: { children: React.ReactNode }) {
+  return (
+    <html>
+      <body>
+        <div>
+          <Link href="/nested">to nested</Link>
+        </div>
+        <div>
+          <Link href="/nested/subroute">to nested subroute</Link>
+        </div>
+        <h1>Root Layout</h1>
+        <div>{children}</div>
+      </body>
+    </html>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/@bar/default.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/@bar/default.tsx
@@ -0,0 +1,7 @@
+export default function Default() {
+  return '@bar default'
+}
+
+export const metadata = {
+  title: '@bar - page',
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/@bar/layout.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/@bar/layout.tsx
@@ -0,0 +1,8 @@
+export default function Layout({ children }) {
+  return (
+    <div>
+      <h1>@bar Layout</h1>
+      <div id="bar-children">{children}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/@bar/page.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/@bar/page.tsx
@@ -0,0 +1,7 @@
+export default function Page() {
+  return <div>Bar Slot</div>
+}
+
+export const metadata = {
+  title: '@bar - page',
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/@bar/subroute/page.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/@bar/subroute/page.tsx
@@ -0,0 +1,7 @@
+export default function Page() {
+  return <div>Subroute</div>
+}
+
+export const metadata = {
+  title: 'subroute - page',
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/@foo/default.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/@foo/default.tsx
@@ -0,0 +1,7 @@
+export default function Default() {
+  return '@foo default'
+}
+
+export const metadata = {
+  title: '@foo - default',
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/@foo/layout.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/@foo/layout.tsx
@@ -0,0 +1,8 @@
+export default function Layout({ children }) {
+  return (
+    <div>
+      <h1>@foo Layout</h1>
+      <div id="foo-children">{children}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/@foo/page.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/@foo/page.tsx
@@ -0,0 +1,7 @@
+export default function Page() {
+  return <div>Foo Slot</div>
+}
+
+export const metadata = {
+  title: '@foo - page',
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/default.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/default.tsx
@@ -0,0 +1,7 @@
+export default function Page() {
+  return 'default page'
+}
+
+export const metadata = {
+  title: 'nested - default',
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/layout.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/layout.tsx
@@ -0,0 +1,10 @@
+export default function Layout({ children, bar, foo }) {
+  return (
+    <div>
+      <h1>Nested Layout</h1>
+      <div id="nested-children">{children}</div>
+      <div id="foo-slot">{foo}</div>
+      <div id="bar-slot">{bar}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/nested/page.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/nested/page.tsx
@@ -0,0 +1,7 @@
+export default function Page() {
+  return <div>Hello from Nested</div>
+}
+
+export const metadata = {
+  title: 'nested - page',
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/app/page.tsx b/test/e2e/app-dir/metadata-parallel-routes/app/page.tsx
@@ -0,0 +1,3 @@
+export default async function Home() {
+  return <div>Hello World</div>
+}
diff --git a/test/e2e/app-dir/metadata-parallel-routes/metadata-parallel-routes.test.ts b/test/e2e/app-dir/metadata-parallel-routes/metadata-parallel-routes.test.ts
@@ -0,0 +1,22 @@
+import { nextTestSetup } from 'e2e-utils'
+
+describe('metadata-parallel-routes', () => {
+  const { next } = nextTestSetup({
+    files: __dirname,
+  })
+
+  it('should ignore metadata from default.js in normal route', async () => {
+    const $ = await next.render$('/')
+    // When there's no title, parallel routes should not affect it
+    expect($('title').length).toBe(0)
+
+    // When there's defined title, parallel routes should not affect it
+    const $nested = await next.render$('/nested')
+    expect($nested('title').text()).toBe('nested - page')
+  })
+
+  it('should ignore metadata from default.js in parallel routes', async () => {
+    const $ = await next.render$('/nested/subroute')
+    expect($('title').text()).toBe('subroute - page')
+  })
+})
diff --git a/test/e2e/app-dir/metadata-parallel-routes/next.config.js b/test/e2e/app-dir/metadata-parallel-routes/next.config.js
@@ -0,0 +1,6 @@
+/**
+ * @type {import('next').NextConfig}
+ */
+const nextConfig = {}
+
+module.exports = nextConfig
diff --git a/test/e2e/app-dir/parallel-routes-layouts/app/nested/@bar/page.tsx b/test/e2e/app-dir/parallel-routes-layouts/app/nested/@bar/page.tsx
@@ -1,3 +1,7 @@
 export default function Page() {
   return <div>Bar Slot</div>
 }
+
+export const metadata = {
+  title: 'nested - page',
+}
diff --git a/test/e2e/app-dir/parallel-routes-layouts/app/nested/@bar/subroute/page.tsx b/test/e2e/app-dir/parallel-routes-layouts/app/nested/@bar/subroute/page.tsx
@@ -1,3 +1,7 @@
 export default function Page() {
   return <div>Subroute</div>
 }
+
+export const metadata = {
+  title: 'subroute - page',
+}
