Enable CSharpMath.Rendering.Tests.TextPainterSettings (#139)

* Fix iOS tests

* Enable TextPainterSettings

* For some reason SkiaSharp produces an errornous image only on Ubuntu??

* i catn spel

* Append OS to tests

Author: Happypig375

.github/workflows/Test all projects.yml

@@ -50,7 +50,7 @@ jobs:
     - uses: actions/upload-artifact@v2
       if: always() # Run even when a previous step failed: https://stackoverflow.com/a/58859404/5429648
       with:
-        name: CSharpMath.Rendering.Tests results
+        name: CSharpMath.Rendering.Tests results (${{ matrix.os }})
         path: CSharpMath.Rendering.Tests/*/*.png
   Ios:
     runs-on: macos-latest

CSharpMath.Apple/AppleMathView.cs

@@ -23,6 +23,19 @@ public class AppleMathView : NView {
     public float FontSize { get; set; } = 20f;
     public ColumnAlignment TextAlignment { get; set; } = ColumnAlignment.Left;
     public NContentInsets ContentInsets { get; set; }
+    private LineStyle _style = LineStyle.Display;
+    public LineStyle LineStyle {
+      get => _style;
+      set {
+        _style = value;
+        if (_mathList != null) {
+          _displayList = Typesetter.CreateLine(_mathList,
+            TFont.LatinMath(FontSize), _typesettingContext, _style);
+        }
+        InvalidateIntrinsicContentSize();
+        SetNeedsLayout();
+      }
+    }
     private MathList _mathList = new MathList();
     public MathList MathList {
       get => _mathList;
@@ -41,7 +54,7 @@ public string LaTeX {
         (_mathList, ErrorMessage) = LaTeXParser.MathListFromLaTeX(value);
         if (_mathList != null) {
           _displayList = Typesetter.CreateLine(_mathList,
-            TFont.LatinMath(FontSize), _typesettingContext, LineStyle.Display);
+            TFont.LatinMath(FontSize), _typesettingContext, _style);
         }
         InvalidateIntrinsicContentSize();
         SetNeedsLayout();

CSharpMath.Ios.Tests/Tests.cs

@@ -10,11 +10,12 @@ public class Tests {
     const double FileSizeTolerance = 0.95; // This is too large... We need to devise an alternative test mechanism
     static readonly Func<string, System.IO.Stream> GetManifestResourceStream =
       System.Reflection.Assembly.GetExecutingAssembly().GetManifestResourceStream;
-    async Task Test(string directory, string file, string latex) {
+    async Task Test(string directory, Action<Apple.AppleMathView> init, string file, string latex) {
       var source = new TaskCompletionSource<UIKit.UIImage>();
       Foundation.NSRunLoop.Main.BeginInvokeOnMainThread(() => {
         try {
           using var v = IosMathLabels.MathView(latex, 50);
+          init(v);
           var size = v.SizeThatFits(default);
           v.Frame = new CoreGraphics.CGRect(default, size);
           UIKit.UIGraphics.BeginImageContext(size);
@@ -54,10 +55,10 @@ async Task Test(string directory, string file, string latex) {
     [Theory]
     [ClassData(typeof(TestData))]
     public Task MathInline(string file, string latex) =>
-      Test(nameof(MathInline), file, latex);
+      Test(nameof(MathInline), v => v.LineStyle = Atom.LineStyle.Text, file, latex);
     [Theory]
     [ClassData(typeof(TestData))]
     public Task MathDisplay(string file, string latex) =>
-      Test(nameof(MathDisplay), file, latex);
+      Test(nameof(MathDisplay), v => { }, file, latex);
   }
 }

CSharpMath.Rendering.Tests/TestRendering.cs

@@ -137,13 +137,14 @@ protected void Run<TContent>(
         { "Stroke", new TPainter { PaintStyle = PaintStyle.Stroke } },
 #warning For some reason the Avalonia front end behaves correctly for TextPainter Magnification test but not the SkiaSharp front end??
         { "Magnification", new TPainter { Magnification = 2 } },
-        { "LocalTypeface", new TPainter {
-          LocalTypefaces = new[] {
-            new Typography.OpenFont.OpenFontReader().Read(
-              TestRenderingFixture.ThisDirectory.EnumerateFiles("ComicNeue_Bold.otf").Single().OpenRead()
-            ) ?? throw new Structures.InvalidCodePathException("Invalid font!")
-          }
-        } },
+#warning For some reason SkiaSharp produces an erroneous image only on Ubuntu??
+        //{ "LocalTypeface", new TPainter {
+        //  LocalTypefaces = new[] {
+        //    new Typography.OpenFont.OpenFontReader().Read(
+        //      TestRenderingFixture.ThisDirectory.EnumerateFiles("ComicNeue_Bold.otf").Single().OpenRead()
+        //    ) ?? throw new Structures.InvalidCodePathException("Invalid font!")
+        //  }
+        //} },
         { "TextLineStyle", new TPainter { LineStyle = Atom.LineStyle.Text } },
         { "ScriptLineStyle", new TPainter { LineStyle = Atom.LineStyle.Script } },
         { "ScriptScriptLineStyle", new TPainter { LineStyle = Atom.LineStyle.ScriptScript } },
@@ -160,8 +161,7 @@ protected void Run<TContent>(
     [MemberData(nameof(MathPainterSettingsData))]
     public virtual void MathPainterSettings(string file, TMathPainter painter) =>
       Run(file, @"\sqrt[3]\frac\color{#F00}a\mathbb C", painter);
-#warning Awaiting CI fix
-    [SkippableTheory(Skip="Awaiting CI fix")]
+    [SkippableTheory]
     [MemberData(nameof(TextPainterSettingsData))]
     public void TextPainterSettings(string file, TTextPainter painter) =>
       Run(file, @"Inline \color{red}{Maths}: $\int_{a_1^2}^{a_2^2}\color{green}\sqrt\frac x2dx$Display \color{red}{Maths}: $$\int_{a_1^2}^{a_2^2}\color{green}\sqrt\frac x2dx$$", painter);