Skip to content

Commit 583c963

Browse files
authored
Merge pull request #35942 from vespa-engine/bjorncs/schema-language-server
Fix schema language server build failure due to MetricReceiver dependency
2 parents a4fe0bb + b5c6717 commit 583c963

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

  • indexinglanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions
  • integration/schema-language-server/language-server/src/main/ccc/indexinglanguage

indexinglanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/EmbedExpression.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,17 @@ public class EmbedExpression extends Expression {
5555
/** The destination the embedding will be written to on the form [schema name].[field name] */
5656
private String destination;
5757

58+
public EmbedExpression(Linguistics linguistics, Components<Embedder> embedders, String embedderId,
59+
List<String> arguments) {
60+
this.linguistics = linguistics;
61+
this.requestedEmbedderId = embedderId;
62+
embedder = new Components.Selected<>("embedder", embedders, embedderId, true, arguments);
63+
this.batcher = null;
64+
this.batchSize = null;
65+
this.batchQueueTime = null;
66+
this.batchCount = null;
67+
}
68+
5869
public EmbedExpression(Linguistics linguistics, Components<Embedder> embedders, String embedderId,
5970
List<String> arguments, MetricReceiver metricReceiver) {
6071
this.linguistics = linguistics;
@@ -288,6 +299,7 @@ private List<Tensor> executeBatch(BatchKey key, List<EmbedInput> inputs) {
288299
}
289300

290301
private void emitBatchMetrics(BatchKey key, List<EmbedInput> inputs) {
302+
if (batchSize == null) return;
291303
var point = new Point(Map.of("embedder", embedder.id(),
292304
"language", key.language().languageCode(),
293305
"destination", key.destination()));

integration/schema-language-server/language-server/src/main/ccc/indexinglanguage/IndexingParser.ccc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ INJECT IndexingParser:
2828
import com.yahoo.language.process.Embedder;
2929
import com.yahoo.language.process.FieldGenerator;
3030
import com.yahoo.language.Linguistics;
31-
import com.yahoo.metrics.simple.MetricReceiver;
3231
{
3332
/**
3433
* @author Simon Thoresen Hult
@@ -479,7 +478,7 @@ Expression embedExp() :
479478
<EMBED> [ SCAN((identifierStr)+) => (embedderId = identifierStr()) ] arguments = arguments()
480479
)
481480
{
482-
return new EmbedExpression(linguistics, embedders, embedderId, arguments, MetricReceiver.nullImplementation);
481+
return new EmbedExpression(linguistics, embedders, embedderId, arguments);
483482
}
484483
;
485484

0 commit comments

Comments
 (0)