Merge pull request #35580 from vespa-engine/hmusum/make-sure-to-close-transaction

hmusum · web-flow · commit 9b8b5b3a1ccc · 2026-01-11T07:57:44.000+01:00
Make sure to close transaction
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/session/SessionZooKeeperClient.java b/configserver/src/main/java/com/yahoo/vespa/config/server/session/SessionZooKeeperClient.java
@@ -105,8 +105,8 @@ public SessionZooKeeperClient(Curator curator, TenantName tenantName, long sessi
     }
 
     public void writeStatus(Session.Status sessionStatus) {
-        try {
-            createWriteStatusTransaction(sessionStatus).commit();
+        try (var transaction = createWriteStatusTransaction(sessionStatus)) {
+            transaction.commit();
         } catch (Exception e) {
             throw new RuntimeException("Unable to write session status", e);
         }

Original file line number	Diff line number	Diff line change
`@@ -105,8 +105,8 @@ public SessionZooKeeperClient(Curator curator, TenantName tenantName, long sessi`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`public void writeStatus(Session.Status sessionStatus) {`
`108`		`- try {`
`109`		`- createWriteStatusTransaction(sessionStatus).commit();`
	`108`	`+ try (var transaction = createWriteStatusTransaction(sessionStatus)) {`
	`109`	`+ transaction.commit();`
`110`	`110`	`} catch (Exception e) {`
`111`	`111`	`throw new RuntimeException("Unable to write session status", e);`
`112`	`112`	`}`