Skip to content

Commit c8f4e79

Browse files
authored
Merge pull request #33863 from vespa-engine/magnus/lsp-deploy-changenotes
Magnus/lsp deploy changenotes
2 parents b1e24fd + 69c481a commit c8f4e79

7 files changed

Lines changed: 24 additions & 7 deletions

File tree

.github/workflows/lspDeploy.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ jobs:
8080
env:
8181
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8282
run: |
83+
echo "## What's New" | cat ./clients/github-release/README.md.in - ./resources/CHANGENOTES.txt > ./clients/github-release/README.md
8384
gh release create lsp-v${{ steps.retrieve_version.outputs.VERSION }} \
8485
--notes-file ./clients/github-release/README.md \
8586
--latest=false \

integration/schema-language-server/clients/github-release/README.md renamed to integration/schema-language-server/clients/github-release/README.md.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,4 @@ lspconfig.schemals.setup{
5050
```
5151

5252
### Manual Installation
53-
If you don't want to use lspconfig you can refer to the [LSP documentation for Neovim](https://neovim.io/doc/user/lsp.html) for manually registering the server.
53+
If you don't want to use lspconfig you can refer to the [LSP documentation for Neovim](https://neovim.io/doc/user/lsp.html) for manually registering the server.

integration/schema-language-server/clients/intellij/build.gradle.kts

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,14 @@ plugins {
66

77
group = "ai.vespa.schemals"
88
version = File("VERSION").inputStream().readBytes().toString(Charsets.UTF_8).trim()
9+
val changeNotesTxt = File("../../resources/CHANGENOTES.txt").inputStream().readBytes().toString(Charsets.UTF_8)
910
val JAVA_VERSION = "17"
1011

1112
repositories {
1213
mavenCentral()
1314

15+
mavenLocal()
16+
1417
maven {
1518
url = uri("https://repo.eclipse.org/content/repositories/lemminx")
1619
metadataSources {
@@ -19,7 +22,6 @@ repositories {
1922
}
2023
}
2124

22-
mavenLocal()
2325
maven {
2426
url = uri("file://${System.getProperty("user.home")}/.m2/repository")
2527
metadataSources {
@@ -101,6 +103,19 @@ tasks {
101103
patchPluginXml {
102104
sinceBuild.set("232")
103105
untilBuild.set(provider { null })
106+
107+
// Split changeNotesTxt into lines and wrap each line in <li></li>
108+
changeNotes.set(
109+
buildString {
110+
append("<ul>")
111+
changeNotesTxt
112+
.lineSequence()
113+
.filter { it.isNotBlank() }
114+
.map { it.trim().removePrefix("-").trim() }
115+
.forEach { append("<li>$it</li>") }
116+
append("</ul>")
117+
}
118+
)
104119
}
105120

106121
signPlugin {

integration/schema-language-server/clients/intellij/src/main/resources/META-INF/plugin.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@
3232
The plugin requires <a href="https://docs.vespa.ai/en/vespa-cli.html">Vespa CLI</a> to be installed to be able to run Vespa Queries from <code>.yql</code> files.
3333
3434
]]></description>
35-
<change-notes><![CDATA[
36-
<h2>Simple support for YQL</h2>
37-
The plugin now supports syntax highlighting of <code>.yql</code> files, in addition to run the queries directly from the editor.
38-
]]></change-notes>
3935
<depends>com.intellij.modules.platform</depends>
4036
<depends>com.redhat.devtools.lsp4ij</depends>
4137
<extensions defaultExtensionNs="com.redhat.devtools.lsp4ij">

integration/schema-language-server/clients/vscode/README.md renamed to integration/schema-language-server/clients/vscode/README.md.in

File renamed without changes.

integration/schema-language-server/clients/vscode/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@
8585
"copy-images": "cp ../../resources/* ./images",
8686
"langserver-install": "mkdir -p server && cp ../../language-server/target/schema-language-server-jar-with-dependencies.jar ./server/ && npm run lemminx-install",
8787
"lemminx-install": "mkdir -p server && cp ../../lemminx-vespa/target/lemminx-vespa-jar-with-dependencies.jar ./server/",
88-
"publish": "npm run compile && node out/publish.js"
88+
"changenotes": "echo \"## What's New\" | cat ./README.md.in - ../../resources/CHANGENOTES.txt > README.md",
89+
"publish": "npm run compile && npm run changenotes && node out/publish.js"
8990
},
9091
"devDependencies": {
9192
"@types/hasbin": "^1.2.2",
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
- Added support for formatting Schema files and selections.
2+
- Added progress indication when indexing large workspaces.
3+
- Added basic support for completion in YQL files.
4+
- Minor bug fixes.

0 commit comments

Comments
 (0)