Merge pull request #36938 from vespa-engine/toregge/restrict-flush-orders-for-gc-targets

Don't select tls size or max age flush order due to gc flush targets MERGEOK.

Author: vekterli

searchcore/src/vespa/searchcore/proton/server/memoryflush.cpp

@@ -154,7 +154,8 @@ FlushContext::List MemoryFlush::getFlushTargets(const FlushContext::List&
         // Don't consider TLSSIZE if there exists an active (ongoing) flush (for this flush handler)
         // that started before the last flush time of the flush target to evaluate.
         // Instead we should wait for the active (ongoing) flush to be finished before doing another evaluation.
-        if (!oldest_start_time.has_value() || lastFlushTime < oldest_start_time.value()) {
+        if ((!oldest_start_time.has_value() || lastFlushTime < oldest_start_time.value()) &&
+            target.getType() != IFlushTarget::Type::GC) {
             if (visitedHandlers.insert(&handler).second) {
                 totalTlsSize += tlsStats.getNumBytes();
                 if ((totalTlsSize > config.maxGlobalTlsSize) && (order < TLSSIZE)) {
@@ -166,7 +167,8 @@ FlushContext::List MemoryFlush::getFlushTargets(const FlushContext::List&
             order = MEMORY;
         } else if ((dgain.gain() > config.diskBloatFactor * computeGain(dgain)) && (order < DISKBLOAT)) {
             order = DISKBLOAT;
-        } else if ((timeDiff >= config.maxTimeGain) && (order < MAXAGE)) {
+        } else if ((timeDiff >= config.maxTimeGain) && (order < MAXAGE) &&
+                   target.getType() != IFlushTarget::Type::GC) {
             order = MAXAGE;
         }
         LOG(debug,