Skip to content

Commit

Permalink
Merge pull request #33228 from vespa-engine/havardpe/tag-as-hidden
Browse files Browse the repository at this point in the history
tag stuff related to tracedoctor as hidden
  • Loading branch information
havardpe authored Jan 31, 2025
2 parents 183df20 + 9a5f650 commit fc95772
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
18 changes: 8 additions & 10 deletions client/go/internal/cli/cmd/inspect.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,10 @@ func newInspectProfileCmd(cli *CLI) *cobra.Command {
opts := inspectProfileOptions{}

cmd := &cobra.Command{
Use: "profile",
Short: "Inspect profiling results",
Long: `Inspect profiling results previously obtained by vespa query --profile
Note: this feature is experimental and currently under development
profiling results can also be analyzed with vespa-query-analyzer (part of vespa installation)`,

Use: "profile",
Hidden: true,
Short: "Inspect profiling results",
Long: `Inspect profiling results previously obtained by vespa query --profile`,
RunE: func(cmd *cobra.Command, args []string) error {
return inspectProfile(cli, &opts)
},
Expand All @@ -63,9 +60,10 @@ profiling results can also be analyzed with vespa-query-analyzer (part of vespa

func newInspectCmd(cli *CLI) *cobra.Command {
cmd := &cobra.Command{
Use: "inspect",
Short: "Provides insight",
Long: "Provides subcommands to inspect various things in more detail",
Use: "inspect",
Hidden: true,
Short: "Provides insight",
Long: "Provides subcommands to inspect various things in more detail",
}
cmd.AddCommand(newInspectProfileCmd(cli))
return cmd
Expand Down
2 changes: 2 additions & 0 deletions client/go/internal/cli/cmd/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ can be set by the syntax [parameter-name]=[value].`,
cmd.Flags().IntVarP(&opts.queryTimeoutSecs, "timeout", "T", 10, "Timeout for the query in seconds")
cmd.Flags().BoolVarP(&opts.profile, "profile", "", false, "Enable profiling mode (Note: this feature is experimental)")
cmd.Flags().StringVarP(&opts.profileFile, "profile-file", "", "vespa_query_profile_result.json", "Profiling result file")
cmd.Flags().MarkHidden("profile")
cmd.Flags().MarkHidden("profile-file")
cli.bindWaitFlag(cmd, 0, &opts.waitSecs)
return cmd
}
Expand Down

0 comments on commit fc95772

Please sign in to comment.