Skip to content

Commit dc2ec32

Browse files
authored
DATA-3916 Remove reason (#673)
1 parent 4ec73bd commit dc2ec32

File tree

4 files changed

+72
-119
lines changed

4 files changed

+72
-119
lines changed

app/datapipelines/v1/data_pipelines.pb.go

+71-81
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/js/app/datapipelines/v1/data_pipelines_pb.d.ts

-4
Original file line numberDiff line numberDiff line change
@@ -445,9 +445,6 @@ export class PipelineRun extends jspb.Message {
445445
getStatus(): PipelineRunStatusMap[keyof PipelineRunStatusMap];
446446
setStatus(value: PipelineRunStatusMap[keyof PipelineRunStatusMap]): void;
447447

448-
getReason(): string;
449-
setReason(value: string): void;
450-
451448
serializeBinary(): Uint8Array;
452449
toObject(includeInstance?: boolean): PipelineRun.AsObject;
453450
static toObject(includeInstance: boolean, msg: PipelineRun): PipelineRun.AsObject;
@@ -466,7 +463,6 @@ export namespace PipelineRun {
466463
dataStartTime?: google_protobuf_timestamp_pb.Timestamp.AsObject,
467464
dataEndTime?: google_protobuf_timestamp_pb.Timestamp.AsObject,
468465
status: PipelineRunStatusMap[keyof PipelineRunStatusMap],
469-
reason: string,
470466
}
471467
}
472468

gen/js/app/datapipelines/v1/data_pipelines_pb.js

+1-31
Original file line numberDiff line numberDiff line change
@@ -3328,8 +3328,7 @@ proto.viam.app.datapipelines.v1.PipelineRun.toObject = function(includeInstance,
33283328
endTime: (f = msg.getEndTime()) && google_protobuf_timestamp_pb.Timestamp.toObject(includeInstance, f),
33293329
dataStartTime: (f = msg.getDataStartTime()) && google_protobuf_timestamp_pb.Timestamp.toObject(includeInstance, f),
33303330
dataEndTime: (f = msg.getDataEndTime()) && google_protobuf_timestamp_pb.Timestamp.toObject(includeInstance, f),
3331-
status: jspb.Message.getFieldWithDefault(msg, 6, 0),
3332-
reason: jspb.Message.getFieldWithDefault(msg, 7, "")
3331+
status: jspb.Message.getFieldWithDefault(msg, 6, 0)
33333332
};
33343333

33353334
if (includeInstance) {
@@ -3394,10 +3393,6 @@ proto.viam.app.datapipelines.v1.PipelineRun.deserializeBinaryFromReader = functi
33943393
var value = /** @type {!proto.viam.app.datapipelines.v1.PipelineRunStatus} */ (reader.readEnum());
33953394
msg.setStatus(value);
33963395
break;
3397-
case 7:
3398-
var value = /** @type {string} */ (reader.readString());
3399-
msg.setReason(value);
3400-
break;
34013396
default:
34023397
reader.skipField();
34033398
break;
@@ -3473,13 +3468,6 @@ proto.viam.app.datapipelines.v1.PipelineRun.serializeBinaryToWriter = function(m
34733468
f
34743469
);
34753470
}
3476-
f = message.getReason();
3477-
if (f.length > 0) {
3478-
writer.writeString(
3479-
7,
3480-
f
3481-
);
3482-
}
34833471
};
34843472

34853473

@@ -3667,24 +3655,6 @@ proto.viam.app.datapipelines.v1.PipelineRun.prototype.setStatus = function(value
36673655
};
36683656

36693657

3670-
/**
3671-
* optional string reason = 7;
3672-
* @return {string}
3673-
*/
3674-
proto.viam.app.datapipelines.v1.PipelineRun.prototype.getReason = function() {
3675-
return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 7, ""));
3676-
};
3677-
3678-
3679-
/**
3680-
* @param {string} value
3681-
* @return {!proto.viam.app.datapipelines.v1.PipelineRun} returns this
3682-
*/
3683-
proto.viam.app.datapipelines.v1.PipelineRun.prototype.setReason = function(value) {
3684-
return jspb.Message.setProto3StringField(this, 7, value);
3685-
};
3686-
3687-
36883658
/**
36893659
* @enum {number}
36903660
*/

proto/viam/app/datapipelines/v1/data_pipelines.proto

-3
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,6 @@ message PipelineRun {
176176

177177
// The status of the run.
178178
PipelineRunStatus status = 6;
179-
180-
// An optional message related to the run status.
181-
string reason = 7;
182179
}
183180

184181
enum PipelineRunStatus {

0 commit comments

Comments
 (0)