Skip to content

Commit ecab331

Browse files
DATA-3969 - Add custom args to training metadata (#693)
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 4683adf commit ecab331

File tree

6 files changed

+219
-160
lines changed

6 files changed

+219
-160
lines changed

app/mltraining/v1/ml_training.pb.go

Lines changed: 177 additions & 155 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/js/app/mltraining/v1/ml_training_pb.d.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,8 @@ export class TrainingJobMetadata extends jspb.Message {
290290
setTagsList(value: Array<string>): void;
291291
addTags(value: string, index?: number): string;
292292

293+
getArgumentsMap(): jspb.Map<string, string>;
294+
clearArgumentsMap(): void;
293295
serializeBinary(): Uint8Array;
294296
toObject(includeInstance?: boolean): TrainingJobMetadata.AsObject;
295297
static toObject(includeInstance: boolean, msg: TrainingJobMetadata): TrainingJobMetadata.AsObject;
@@ -320,6 +322,7 @@ export namespace TrainingJobMetadata {
320322
trainingEnded?: google_protobuf_timestamp_pb.Timestamp.AsObject,
321323
syncedModelId: string,
322324
tagsList: Array<string>,
325+
argumentsMap: Array<[string, string]>,
323326
}
324327
}
325328

gen/js/app/mltraining/v1/ml_training_pb.js

Lines changed: 34 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1942,7 +1942,8 @@ proto.viam.app.mltraining.v1.TrainingJobMetadata.toObject = function(includeInst
19421942
trainingStarted: (f = msg.getTrainingStarted()) && google_protobuf_timestamp_pb.Timestamp.toObject(includeInstance, f),
19431943
trainingEnded: (f = msg.getTrainingEnded()) && google_protobuf_timestamp_pb.Timestamp.toObject(includeInstance, f),
19441944
syncedModelId: jspb.Message.getFieldWithDefault(msg, 5, ""),
1945-
tagsList: (f = jspb.Message.getRepeatedField(msg, 16)) == null ? undefined : f
1945+
tagsList: (f = jspb.Message.getRepeatedField(msg, 16)) == null ? undefined : f,
1946+
argumentsMap: (f = msg.getArgumentsMap()) ? f.toObject(includeInstance, undefined) : []
19461947
};
19471948

19481949
if (includeInstance) {
@@ -2056,6 +2057,12 @@ proto.viam.app.mltraining.v1.TrainingJobMetadata.deserializeBinaryFromReader = f
20562057
var value = /** @type {string} */ (reader.readString());
20572058
msg.addTags(value);
20582059
break;
2060+
case 21:
2061+
var value = msg.getArgumentsMap();
2062+
reader.readMessage(value, function(message, reader) {
2063+
jspb.Map.deserializeBinary(message, reader, jspb.BinaryReader.prototype.readString, jspb.BinaryReader.prototype.readString, null, "", "");
2064+
});
2065+
break;
20592066
default:
20602067
reader.skipField();
20612068
break;
@@ -2216,6 +2223,10 @@ proto.viam.app.mltraining.v1.TrainingJobMetadata.serializeBinaryToWriter = funct
22162223
f
22172224
);
22182225
}
2226+
f = message.getArgumentsMap(true);
2227+
if (f && f.getLength() > 0) {
2228+
f.serializeBinary(21, writer, jspb.BinaryWriter.prototype.writeString, jspb.BinaryWriter.prototype.writeString);
2229+
}
22192230
};
22202231

22212232

@@ -2657,6 +2668,28 @@ proto.viam.app.mltraining.v1.TrainingJobMetadata.prototype.clearTagsList = funct
26572668
};
26582669

26592670

2671+
/**
2672+
* map<string, string> arguments = 21;
2673+
* @param {boolean=} opt_noLazyCreate Do not create the map if
2674+
* empty, instead returning `undefined`
2675+
* @return {!jspb.Map<string,string>}
2676+
*/
2677+
proto.viam.app.mltraining.v1.TrainingJobMetadata.prototype.getArgumentsMap = function(opt_noLazyCreate) {
2678+
return /** @type {!jspb.Map<string,string>} */ (
2679+
jspb.Message.getMapField(this, 21, opt_noLazyCreate,
2680+
null));
2681+
};
2682+
2683+
2684+
/**
2685+
* Clears values from the map. The map will be non-null.
2686+
* @return {!proto.viam.app.mltraining.v1.TrainingJobMetadata} returns this
2687+
*/
2688+
proto.viam.app.mltraining.v1.TrainingJobMetadata.prototype.clearArgumentsMap = function() {
2689+
this.getArgumentsMap().clear();
2690+
return this;};
2691+
2692+
26602693

26612694

26622695

proto/viam/app/mltraining/v1/ml_training.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ message TrainingJobMetadata {
123123
google.protobuf.Timestamp training_ended = 10 [(tagger.v1.tags) = "bson:\"training_ended\" json:\"training_ended\""];
124124
string synced_model_id = 5 [(tagger.v1.tags) = "bson:\"synced_model_id\" json:\"synced_model_id\""];
125125
repeated string tags = 16 [(tagger.v1.tags) = "bson:\"tags\" json:\"tags\""];
126+
map<string, string> arguments = 21 [(tagger.v1.tags) = "bson:\"arguments\" json:\"arguments\""];
126127

127128
reserved 1, 6;
128129
reserved "request", "user_email";

robot/v1/robot.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/slam/v1/slam.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)