Add new Split overload for C# 14 (#789)

Author: viceroypenguin

Source/SuperLinq/Split.cs

@@ -35,6 +35,40 @@ TSource separator
 		return Split(source, separator, count: int.MaxValue);
 	}
 
+	/// <summary>
+	///	    Splits the source sequence by a separator.
+	/// </summary>
+	/// <typeparam name="TSource">
+	///	    Type of element in the source sequence.
+	/// </typeparam>
+	/// <param name="source">
+	///	    The source sequence.
+	/// </param>
+	/// <param name="separator">
+	///	    Separator element.
+	/// </param>
+	/// <exception cref="ArgumentNullException">
+	///	    <paramref name="source"/> is <see langword="null"/>.
+	/// </exception>
+	/// <returns>
+	///	    A sequence of splits of elements.
+	/// </returns>
+	/// <remarks>
+	/// <para>
+	///	    This method is implemented by using deferred execution and streams the groupings. The grouping elements,
+	///     however, are buffered. Each grouping is therefore yielded as soon as it is complete and before the next
+	///     grouping occurs.
+	/// </para>
+	/// </remarks>
+	// Exists because in C# 14, `MemoryExtensions.Split()` binds tighter
+	public static IEnumerable<IReadOnlyList<TSource>> Split<TSource>(
+		this TSource[] source,
+		TSource separator
+	)
+	{
+		return Split(source, separator, count: int.MaxValue);
+	}
+
 	/// <summary>
 	///	    Splits the source sequence by a separator given a maximum count of splits.
 	/// </summary>

Tests/SuperLinq.Tests/SplitArrayTest.cs

@@ -0,0 +1,23 @@
+// Needs to be in non `SuperLinq` namespace for proper testing of overload resolution
+#pragma warning disable IDE0130 // Namespace does not match folder structure
+
+namespace Not.SuperLinq.Tests;
+
+public sealed class SplitArrayTest
+{
+
+	[Fact]
+	public void SplitArray()
+	{
+		var sequence = Enumerable.Range(1, 10).ToArray();
+		var result = sequence.Split(5).ToList();
+
+		result
+			.AssertSequenceEqual(
+				[
+					Enumerable.Range(1, 4),
+					Enumerable.Range(6, 5),
+				]
+			);
+	}
+}

Tests/SuperLinq.Tests/SplitTest.cs

@@ -1,5 +1,3 @@
-using System.Diagnostics.CodeAnalysis;
-
 namespace SuperLinq.Tests;
 
 public sealed class SplitTest
@@ -11,6 +9,21 @@ public void SplitIsLazy()
 		_ = new BreakingSequence<int>().Split(1, 2);
 	}
 
+	[Fact]
+	public void Split()
+	{
+		using var sequence = Enumerable.Range(1, 10).AsTestingSequence();
+		var result = sequence.Split(5);
+
+		result
+			.AssertSequenceEqual(
+				[
+					Enumerable.Range(1, 4),
+					Enumerable.Range(6, 5),
+				]
+			);
+	}
+
 	[Fact]
 	public void SplitWithComparer()
 	{
@@ -28,20 +41,18 @@ public void SplitWithComparerUptoMaxCount()
 	}
 
 	[Fact]
-	[SuppressMessage("Style", "IDE0305:Simplify collection initialization")]
 	public void SplitWithSeparatorAndResultTransformation()
 	{
 		using var sequence = "the quick brown fox".AsTestingSequence();
-		var result = sequence.Split(' ', chars => new string(chars.ToArray()));
+		var result = sequence.Split(' ', chars => new string([.. chars]));
 		result.AssertSequenceEqual("the", "quick", "brown", "fox");
 	}
 
 	[Fact]
-	[SuppressMessage("Style", "IDE0305:Simplify collection initialization")]
 	public void SplitUptoMaxCount()
 	{
 		using var sequence = "the quick brown fox".AsTestingSequence();
-		var result = sequence.Split(' ', 2, chars => new string(chars.ToArray()));
+		var result = sequence.Split(' ', 2, chars => new string([.. chars]));
 		result.AssertSequenceEqual("the", "quick", "brown fox");
 	}