Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization exception for string of length > 1024 #30

Open
XieX opened this issue Apr 28, 2014 · 2 comments
Open

Serialization exception for string of length > 1024 #30

XieX opened this issue Apr 28, 2014 · 2 comments

Comments

@XieX
Copy link
Contributor

XieX commented Apr 28, 2014

When adding an object containing a string of length > 1024, I'm getting a SerializationException, "can not be converted to a Blob: Base64 encoded length is expected a multiple of 4 bytes".

I noticed the arbitrary encoding of all strings of length > 1024 as binary: https://github.com/victorquinn/dynasty/blob/master/src/lib/data-translators.coffee#L51-L57

@mike-zorn
Copy link
Collaborator

I vote we remove all blob type serialization.

@victorquinn
Copy link
Owner

Fine by me, as long as it works!

It's not even entirely clear to me under what circumstances you'd want a Blob and a String would not suffice. (a fair amount of searching turned up nothing)

Further, it appears the fromDynamo method at the top of that file has no Blob translator either so as currently written data could be written to Dynamo but couldn't be read.

So yeah, 100% I agree remove it unless or until we can (1) find a use case (2) figure out a way to translate it to dynamo (3) figure out a way to un-translate it from dynamo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants