Skip to content

Commit 9a8ba4a

Browse files
blammitchriadam
authored andcommitted
Respect write access in spinbox, date/time selectors and misc buttons
Fixes #1764 (cherry picked from commit 3c18855)
1 parent bc0fa11 commit 9a8ba4a

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

components/listitems/ListDateSelector.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ ListButton {
1515
property var date: dataItem.isValid ? new Date(dataItem.value * 1000) : null
1616

1717
button.text: date == null ? "--" : Qt.formatDate(date, "yyyy-MM-dd")
18-
enabled: dataItem.uid === "" || dataItem.isValid
18+
enabled: userHasWriteAccess && (dataItem.uid === "" || dataItem.isValid)
1919

2020
onClicked: Global.dialogLayer.open(dateSelectorComponent, {
2121
year: date ? date.getFullYear() : ClockTime.year,

components/listitems/ListSpinBox.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ ListButton {
2525
signal selectorAccepted(newValue: var)
2626

2727
button.text: value === undefined ? "--" : Units.formatNumber(value, decimals) + root.suffix
28-
enabled: dataItem.uid === "" || dataItem.isValid
28+
enabled: userHasWriteAccess && (dataItem.uid === "" || dataItem.isValid)
2929

3030
onClicked: Global.dialogLayer.open(numberSelectorComponent, {value: value})
3131

components/listitems/ListTimeSelector.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ ListButton {
2020
property real value: !dataItem.isValid ? 0 : dataItem.value
2121

2222
button.text: hour < 0 || minute < 0 ? "--" : ClockTime.formatTime(hour, minute)
23-
enabled: dataItem.uid === "" || dataItem.isValid
23+
enabled: userHasWriteAccess && (dataItem.uid === "" || dataItem.isValid)
2424

2525
onClicked: Global.dialogLayer.open(timeSelectorComponent, {hour: hour, minute: minute})
2626

components/settings/FirmwareCheckListButton.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ListButton {
1616
? qsTrId("settings_firmware_checking")
1717
//% "Press to check"
1818
: qsTrId("settings_firmware_press_to_check")
19-
enabled: !Global.firmwareUpdate.busy
19+
enabled: userHasWriteAccess && !Global.firmwareUpdate.busy
2020
writeAccessLevel: VenusOS.User_AccessType_User
2121

2222
onClicked: {

components/settings/ListClearHistoryButton.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ ListButton {
3737
id: timer
3838
interval: 2000
3939
}
40-
enabled: !timer.running
40+
enabled: userHasWriteAccess && !timer.running
4141

4242
onClicked: {
4343
/*

0 commit comments

Comments
 (0)