more test/ pylint

Author: nschloe

Diff for: .pylintrc

@@ -7,6 +7,7 @@ disable=
     invalid-name,
     locally-disabled,
     missing-docstring,
+    no-member,
     too-few-public-methods,
     too-many-branches,
     too-many-statements,

Diff for: test/test_barchart.py

@@ -23,7 +23,7 @@ def plot():
     w = 0.25
 
     ax.bar(x-w, y1, w, color='b', align='center')
-    ax.bar(x,   y2, w, color='g', align='center')
+    ax.bar(x, y2, w, color='g', align='center')
     ax.bar(x+w, y3, w, color='r', align='center')
 
     return fig

Diff for: test/test_barchart_legend.py

@@ -28,7 +28,7 @@ def plot():
     w = 0.25
 
     ax.bar(x-w, y1, w, color='b', align='center', label='Data 1')
-    ax.bar(x,   y2, w, color='g', align='center', label='Data 2')
+    ax.bar(x, y2, w, color='g', align='center', label='Data 2')
     ax.bar(x+w, y3, w, color='r', align='center', label='Data 3')
     ax.legend()
 

Diff for: test/test_fancybox.py

@@ -12,11 +12,11 @@
 bb = mtransforms.Bbox([[0.3, 0.4], [0.7, 0.6]])
 
 
-def draw_bbox(ax, bb):
+def draw_bbox(ax, bb_obj):
     # boxstyle=square with pad=0, i.e. bbox itself.
     p_bbox = FancyBboxPatch(
-            (bb.xmin, bb.ymin),
-            abs(bb.width), abs(bb.height),
+            (bb_obj.xmin, bb_obj.ymin),
+            abs(bb_obj.width), abs(bb_obj.height),
             boxstyle='square,pad=0.',
             ec='k', fc='none', zorder=10.,
             )

Diff for: test/test_heat.py

@@ -9,6 +9,7 @@ def plot():
     import numpy as np
 
     fig = plt.figure()
+    # pylint: disable=invalid-slice-index
     x, y = np.ogrid[-10:10:100j, -10:10:100j]
     extent = (x.min(), x.max(), y.min(), y.max())
     cmap = matplotlib.cm.get_cmap('gray')

Diff for: test/test_legend_best_location.py

@@ -30,12 +30,12 @@ def plot():
 
     # Legend best location is "center left"
     l, = axes[4].plot(t[30:], 2 * np.cos(10 * t[30:]), linewidth=0.5)
-    l2, l3 = axes[4].plot(t, -1.5 * np.ones_like(t), t, 1.5 * np.ones_like(t))
+    axes[4].plot(t, -1.5 * np.ones_like(t), t, 1.5 * np.ones_like(t))
     axes[4].legend((l,), ('CL',), loc=0)
 
     # Legend best location is "center right"
     l, = axes[5].plot(t[:30], 2 * np.cos(10 * t[:30]), linewidth=0.5)
-    l2, l3 = axes[5].plot(t, -1.5 * np.ones_like(t), t, 1.5 * np.ones_like(t))
+    axes[5].plot(t, -1.5 * np.ones_like(t), t, 1.5 * np.ones_like(t))
     axes[5].legend((l,), ('CR',), loc=0)
 
     # Legend best location is "lower center"
@@ -47,9 +47,14 @@ def plot():
     axes[7].legend((l,), ('UC',), loc=0)
 
     # Legend best location is "center"
-    l, l1 = axes[8].plot(t[:10], 2 * np.cos(10 * t[:10]), t[-10:],
-                         2 * np.cos(10 * t[-10:]), linewidth=0.5)
-    l2, l3 = axes[8].plot(t, -2 * np.ones_like(t), t, 2 * np.ones_like(t))
+    l, = axes[8].plot(
+            t[:10],
+            2 * np.cos(10 * t[:10]),
+            t[-10:],
+            2 * np.cos(10 * t[-10:]),
+            linewidth=0.5
+            )
+    axes[8].plot(t, -2 * np.ones_like(t), t, 2 * np.ones_like(t))
     axes[8].legend((l,), ('C',), loc=0)
 
     return fig

Diff for: test/test_legends2.py

@@ -7,7 +7,7 @@ def plot():
     from matplotlib import pyplot as plt
     import numpy as np
 
-    fig, ax = plt.subplots(3, 3,  sharex='col', sharey='row')
+    fig, ax = plt.subplots(3, 3, sharex='col', sharey='row')
     axes = [ax[i][j] for i in range(len(ax)) for j in range(len(ax[i]))]
     for k, loc in enumerate(range(2, 11)):
         t1 = np.arange(0.0, 2.0, 0.1)
@@ -19,10 +19,10 @@ def plot():
         l1, = axes[k].plot(
             t2, np.exp(-t2), linewidth=0.5
             )
-        l2, l3 = axes[k].plot(
+        axes[k].plot(
             t2, np.sin(2*np.pi*t2), '--go', t1, np.log(1+t1), '.'
             )
-        l4, = axes[k].plot(
+        axes[k].plot(
             t2, np.exp(-t2)*np.sin(2*np.pi*t2), 'rs-.'
             )
 

Diff for: test/test_logplot.py

@@ -9,7 +9,7 @@ def plot():
     a = [pow(10, i) for i in range(10)]
     fig = plt.figure()
     ax = fig.add_subplot(1, 1, 1)
-    line, = ax.semilogy(a, color='blue', lw=0.25)
+    ax.semilogy(a, color='blue', lw=0.25)
 
     plt.grid(b=True, which='major', color='g', linestyle='-', linewidth=0.25)
     plt.grid(b=True, which='minor', color='r', linestyle='--', linewidth=0.5)

Diff for: test/test_noise.py

@@ -1,10 +1,11 @@
 # -*- coding: utf-8 -*-
 #
+from __future__ import print_function
+
 import helpers
 
-from numpy.random import randn
-from matplotlib import pyplot as plt
 import numpy as np
+import matplotlib.pyplot as plt
 import pytest
 
 
@@ -14,7 +15,7 @@ def plot1():
     ax = fig.add_subplot(111)
 
     np.random.seed(123)
-    data = np.clip(randn(250, 250), -1, 1)
+    data = np.clip(np.random.randn(250, 250), -1, 1)
 
     cax = ax.imshow(data, interpolation='nearest')
     ax.set_title('Gaussian noise with vertical colorbar')
@@ -59,5 +60,5 @@ def test(plot, reference_phash):
 if __name__ == '__main__':
     # plot1()
     # plt.show()
-    phash, _, _, _, _, _, _ = helpers.compute_phash(plot2())
-    print(phash)
+    ph, _, _, _, _, _, _ = helpers.compute_phash(plot2())
+    print(ph)

Diff for: test/test_patches.py

@@ -49,7 +49,7 @@ def plot():
         Wedge((0.8, 0.3), .2, 45, 90, width=0.10),  # Ring sector
         ]
 
-    for i in range(N):
+    for _ in range(N):
         polygon = Polygon(np.random.rand(N, 2), True)
         patches.append(polygon)
 

Diff for: test/test_rotated_labels.py

@@ -1,10 +1,11 @@
 # -*- coding: utf-8 -*-
 #
+import os
+import tempfile
+
 import matplotlib2tikz
 
 import pytest
-import tempfile
-import os
 from matplotlib import pyplot as plt
 
 
@@ -21,26 +22,28 @@ def __plot():
 
 
 @pytest.mark.parametrize(
-    "x_alignment, y_alignment, x_tick_label_width,"
-    "y_tick_label_width, rotation", [
-        (None,     None,     "1rem", "3rem", 90),
-        (None,     "center", "1rem", "3rem", 90),
-        ("center", None,     "1rem", "3rem", 90),
-        ("center", "center", None,   "3rem", 90),
-        ("left",   "left",   None,   "3rem", 90),
-        ("right",  "right",  None,   "3rem", 90),
-        ("center", "center", "1rem", None,   90),
-        ("left",   "left",   "2rem", None,   90),
-        ("right",  "right",  "3rem", None,   90),
-        ("center", "center", "1rem", "3rem", 90),
-        ("left",   "left",   "2rem", "3rem", 90),
-        ("right",  "right",  "3rem", "3rem", 90),
-        ("left",   "right",  "2rem", "3rem", 90),
-        ("right",  "left",   "3rem", "3rem", 90),
+    'x_alignment, y_alignment, x_tick_label_width,'
+    'y_tick_label_width, rotation', [
+        (None, None, '1rem', '3rem', 90),
+        (None, 'center', '1rem', '3rem', 90),
+        ('center', None, '1rem', '3rem', 90),
+        ('center', 'center', None, '3rem', 90),
+        ('left', 'left', None, '3rem', 90),
+        ('right', 'right', None, '3rem', 90),
+        ('center', 'center', '1rem', None, 90),
+        ('left', 'left', '2rem', None, 90),
+        ('right', 'right', '3rem', None, 90),
+        ('center', 'center', '1rem', '3rem', 90),
+        ('left', 'left', '2rem', '3rem', 90),
+        ('right', 'right', '3rem', '3rem', 90),
+        ('left', 'right', '2rem', '3rem', 90),
+        ('right', 'left', '3rem', '3rem', 90),
     ])
-def test_rotated_labels_parameters(x_alignment, y_alignment,
-                                   x_tick_label_width, y_tick_label_width,
-                                   rotation):
+def test_rotated_labels_parameters(
+        x_alignment, y_alignment,
+        x_tick_label_width, y_tick_label_width,
+        rotation
+        ):
     fig, _ = __plot()
 
     if x_alignment:
@@ -73,14 +76,16 @@ def test_rotated_labels_parameters(x_alignment, y_alignment,
     return
 
 
-@pytest.mark.parametrize("x_tick_label_width, y_tick_label_width", [
-    (None,   None),
-    ("1rem", None),
-    (None,   "3rem"),
-    ("2rem", "3rem"),
+@pytest.mark.parametrize('x_tick_label_width, y_tick_label_width', [
+    (None, None),
+    ('1rem', None),
+    (None, '3rem'),
+    ('2rem', '3rem'),
 ])
-def test_rotated_labels_parameters_different_values(x_tick_label_width,
-                                                    y_tick_label_width):
+def test_rotated_labels_parameters_different_values(
+        x_tick_label_width,
+        y_tick_label_width
+        ):
     fig, ax = __plot()
 
     plt.xticks(ha='left', rotation=90)