Duplicate styles in onRenderClient.css and onRenderHtml.css

[shishkin17]

There used to be just one file generated for styles - onRenderClient.css.

I updated vike and vite (used pretty old versions) and noticed that now it generates more css files including onRenderClient.css and onRenderHtml.css.
I use SSG model. So when I prerender the site I get 2 css files with almost the same content.

I am confused: is this doing vike or vite?
Can you please give a hint if I can control it somehow or make a workaround?

[brillout]

What's your vike-react version?

[shishkin17]

Thank you. I'm glad I was useful in reporting that.

But cssCodeSplit: true leads to duplicated CSS.
So this warning seems to work incorrectly.

[brillout]

But cssCodeSplit: true leads to duplicated CSS.

Minimal reproduction welcome.

[shishkin17]

I mean:
cssCodeSplit: false = 1 css file - no problem
cssCodeSplit: true = multiple css files - duplication problem.

Do you want to say that while digging you found a problem when cssCodeSplit: false, not with cssCodeSplit: true?

[brillout]

Do you want to say that while digging you found a problem when cssCodeSplit: false, not with cssCodeSplit: true?

Yes

[brillout]

Thus minimal reproduction welcome of having duplication problems with cssCodeSplit: true.

[richard-unterberg]

the build warning brought me here. I looked up the build files and the waterfall, cannot reproduce the duplication issue on fresh vike + vike-solid and vite 7.* setups. cssCodeSplit: false / true also works well for vike-react and tailwind and ssr/ssg activated. Also tested on multiple grown up projects with vite 6.*. Neither the content of the css file is duplicated, nor the imports.

I can confirm, there was a time I stumbled upon a similiar issue with a vike-react version, where there was a identical css file built with only one line of code difference. But that seems fixed in the more recent versions. shishkin17 - have you tried newer versions?

@brillout

[richard-unterberg]

sorry, I had missed that shishkin17 is using vike without react adapter.. Will test that tomorrow.

[brillout]

the build warning brought me here

If you use the latest Vike version, you shouldn't be getting the warning The CSS browser target should be the same for both client and server anymore — AFAICT Vike is now clever enough to automatically fix it.

If you do get the warning, the best would be a minimal reproduction.

[richard-unterberg]

If you use the latest Vike version, you shouldn't be getting the warning "The CSS browser target should be the same for both client and server anymore "

Ah sorry, I left you without context - I actually hit this warning build.cssCodeSplit shouldn't be set to false (https://github.com/vikejs/vike/issues/1993) which linked to the discussion here..

[brillout]

No problems. I've updated #1993 to be clearer — it now explains what the root cause is.

Let's wait for Vite to fully adopt Rolldown, let's then see if we can remove the warning.