Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing index filters to methods for selection purposes #1

Open
viktorvanwijk opened this issue Apr 9, 2024 · 0 comments
Open

Passing index filters to methods for selection purposes #1

viktorvanwijk opened this issue Apr 9, 2024 · 0 comments
Labels
investigation question Further information is requested

Comments

@viktorvanwijk
Copy link
Owner

viktorvanwijk commented Apr 9, 2024

Example of current implementation:

def filter_job_descriptions(
    df: DataFrame, keyword: str, index_filter: Optional[pandas.Index] = None
) -> DataFrame:
    df_temp = df.loc[index_filter, :] if index_filter is not None else df
    ...

Is this the best way? Ideally these methods should just accept a dataframe, but not sure how to put the data in the original dataframe otherwise.

@viktorvanwijk viktorvanwijk changed the title Passing index filters to functions for selection purposes Passing index filters to methods for selection purposes Apr 9, 2024
@viktorvanwijk viktorvanwijk added question Further information is requested investigation labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant